From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
To: benh@kernel.crashing.org
Cc: Sergei Shtylyov <sshtylyov@ru.mvista.com>,
Linux IDE <linux-ide@vger.kernel.org>,
linux-kernel@vger.kernel.org, Andrew Morton <akpm@osdl.org>
Subject: Re: [PATCH 2/3] ide: Fix siimage driver accessing beyond array boundary
Date: Thu, 18 Oct 2007 23:30:42 +0200 [thread overview]
Message-ID: <200710182330.43052.bzolnier@gmail.com> (raw)
In-Reply-To: <1192709764.12879.66.camel@pasglop>
On Thursday 18 October 2007, Benjamin Herrenschmidt wrote:
>
> On Thu, 2007-10-18 at 16:02 +0400, Sergei Shtylyov wrote:
> > Benjamin Herrenschmidt wrote:
> >
> > > The siimage use an incorrect construct to access the other drive
> > > of a pair, causing it to access beyond an array boundary on non-0
> > > interfaces. This fixes it by using the new ide_get_paired_drive()
> > > hepler instead.
> >
> > > Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
> >
> > Please update the driver version in the driver's heading comment. Otherwise
> >
> > Acked-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>
>
> I don't believe much in driver versions in tree... the kernel version is
> what matter... Bart, what's your stance there ?
Similar opinion here but sometimes driver versions are useful, i.e.:
* during development or while debugging regressions to distinguish
real changes (which have to update driver version) from the core
changes and trivial cleanups (which don't do this)
* bugreports with partial dmesg info (hmm, doesn't matter for IDE
currently since we don't print this info - patches are welcomed)
* maybe some other that I forgot :)
I updated siimage driver version in separate commit
(no need to do it for cs5535 since it lacks driver version).
Thanks,
Bart
next prev parent reply other threads:[~2007-10-18 22:50 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-18 0:56 [PATCH 0/3] ide: Fix use of paired device Benjamin Herrenschmidt
2007-10-18 0:56 ` [PATCH 1/3] ide: Add ide_get_paired_drive() helper Benjamin Herrenschmidt
2007-10-18 12:00 ` Sergei Shtylyov
2007-10-18 21:10 ` Bartlomiej Zolnierkiewicz
2007-10-18 0:56 ` [PATCH 2/3] ide: Fix siimage driver accessing beyond array boundary Benjamin Herrenschmidt
2007-10-18 12:02 ` Sergei Shtylyov
2007-10-18 12:16 ` Benjamin Herrenschmidt
2007-10-18 21:30 ` Bartlomiej Zolnierkiewicz [this message]
2007-10-18 21:10 ` Bartlomiej Zolnierkiewicz
2007-10-18 0:56 ` [PATCH 3/3] ide: Fix cs5535 " Benjamin Herrenschmidt
2007-10-18 12:03 ` Sergei Shtylyov
2007-10-18 21:10 ` Bartlomiej Zolnierkiewicz
2007-10-18 11:54 ` [PATCH 0/3] ide: Fix use of paired device Sergei Shtylyov
2007-10-18 11:58 ` Sergei Shtylyov
2007-10-18 12:14 ` Benjamin Herrenschmidt
2007-10-18 20:29 ` Bartlomiej Zolnierkiewicz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200710182330.43052.bzolnier@gmail.com \
--to=bzolnier@gmail.com \
--cc=akpm@osdl.org \
--cc=benh@kernel.crashing.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sshtylyov@ru.mvista.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).