* [2.6 patch] ide/pci/sis5513.c: add missing "else"
@ 2007-10-19 14:04 Adrian Bunk
2007-10-19 21:00 ` Bartlomiej Zolnierkiewicz
0 siblings, 1 reply; 2+ messages in thread
From: Adrian Bunk @ 2007-10-19 14:04 UTC (permalink / raw)
To: Sergei Shtylyov, Bartlomiej Zolnierkiewicz; +Cc: linux-ide, linux-kernel
This patch adds a missing "else" that was missing in
commit c77a89cd98d99819f23a4a08e5e17ee1f13f6e4d.
Spotted by the Coverity checker.
Signed-off-by: Adrian Bunk <bunk@kernel.org>
---
2e4b8d4f58ea45e55c87ba5563b0d0e135cac2b4
diff --git a/drivers/ide/pci/sis5513.c b/drivers/ide/pci/sis5513.c
index c1d280b..1680926 100644
--- a/drivers/ide/pci/sis5513.c
+++ b/drivers/ide/pci/sis5513.c
@@ -264,7 +264,7 @@ static void sis_ata133_program_timings(ide_drive_t *drive, const u8 mode)
if (mode >= XFER_MW_DMA_0) {
t1 &= ~0x04; /* disable UDMA */
idx = mode - XFER_MW_DMA_0 + 5;
- }
+ } else
idx = mode - XFER_PIO_0;
t1 |= ini_time_value[clk][idx] << 12;
t1 |= act_time_value[clk][idx] << 16;
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [2.6 patch] ide/pci/sis5513.c: add missing "else"
2007-10-19 14:04 [2.6 patch] ide/pci/sis5513.c: add missing "else" Adrian Bunk
@ 2007-10-19 21:00 ` Bartlomiej Zolnierkiewicz
0 siblings, 0 replies; 2+ messages in thread
From: Bartlomiej Zolnierkiewicz @ 2007-10-19 21:00 UTC (permalink / raw)
To: Adrian Bunk; +Cc: Sergei Shtylyov, linux-ide, linux-kernel
On Friday 19 October 2007, Adrian Bunk wrote:
> This patch adds a missing "else" that was missing in
> commit c77a89cd98d99819f23a4a08e5e17ee1f13f6e4d.
>
> Spotted by the Coverity checker.
>
> Signed-off-by: Adrian Bunk <bunk@kernel.org>
applied, thanks!
> ---
> 2e4b8d4f58ea45e55c87ba5563b0d0e135cac2b4
> diff --git a/drivers/ide/pci/sis5513.c b/drivers/ide/pci/sis5513.c
> index c1d280b..1680926 100644
> --- a/drivers/ide/pci/sis5513.c
> +++ b/drivers/ide/pci/sis5513.c
> @@ -264,7 +264,7 @@ static void sis_ata133_program_timings(ide_drive_t *drive, const u8 mode)
> if (mode >= XFER_MW_DMA_0) {
> t1 &= ~0x04; /* disable UDMA */
> idx = mode - XFER_MW_DMA_0 + 5;
> - }
> + } else
> idx = mode - XFER_PIO_0;
> t1 |= ini_time_value[clk][idx] << 12;
> t1 |= act_time_value[clk][idx] << 16;
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2007-10-19 21:00 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-10-19 14:04 [2.6 patch] ide/pci/sis5513.c: add missing "else" Adrian Bunk
2007-10-19 21:00 ` Bartlomiej Zolnierkiewicz
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).