linux-ide.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: barkalow@iabervon.org
Cc: linux-kernel@vger.kernel.org, jeff@garzik.org,
	linas@austin.ibm.com, chunhao.huang@hotmail.com, gregkh@suse.de,
	htejun@gmail.com, brice.goglin@gmail.com,
	david.gaarenstroom@gmail.com, linux-pci@atrey.karlin.mff.cuni.cz,
	shane.huang@amd.com, linux-ide@vger.kernel.org, brice@myri.com,
	mchan@broadcom.com
Subject: Re: [PATCH 0/4]: Resolve MSI vs. INTX_DISABLE quirks.
Date: Tue, 23 Oct 2007 22:06:22 -0700 (PDT)	[thread overview]
Message-ID: <20071023.220622.68038077.davem@davemloft.net> (raw)
In-Reply-To: <Pine.LNX.4.64.0710240046220.32497@iabervon.org>

From: Daniel Barkalow <barkalow@iabervon.org>
Date: Wed, 24 Oct 2007 00:58:45 -0400 (EDT)

> I'm not sure all of the pci_intx() calls in msi.c should be skipped when 
> the quirk applies; I think some of them might be there so that the legacy 
> interrupt won't be delivered while MSI is turned off (since the handler 
> isn't listening for the legacy interrupts). I'd guess this would cause 
> people to have their MSI-capable device kill their non-MSI-capable device 
> when they restore their laptop (and the shared interrupt fires and gets 
> stuck at just the wrong time). No idea if this is a real concern, but I'm 
> pretty sure that not all of those calls are recent.

I don't think it's a real concern.

> There's a couple of ATA drivers that look like they might be trying to 
> work around the same bug, but it's a bit hard to tell. It might be good to 
> have them use the quirk (or set the flag) because it's cleaner.

I noticed these cases as well, and I would hope that Jeff would help
out here using the infrastructure my patches created.

  reply	other threads:[~2007-10-24  5:06 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-10-24  2:51 [PATCH 0/4]: Resolve MSI vs. INTX_DISABLE quirks David Miller
2007-10-24  4:58 ` Daniel Barkalow
2007-10-24  5:06   ` David Miller [this message]
2007-10-24 16:52     ` Daniel Barkalow
2007-10-25  5:37 ` Jeff Garzik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20071023.220622.68038077.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=barkalow@iabervon.org \
    --cc=brice.goglin@gmail.com \
    --cc=brice@myri.com \
    --cc=chunhao.huang@hotmail.com \
    --cc=david.gaarenstroom@gmail.com \
    --cc=gregkh@suse.de \
    --cc=htejun@gmail.com \
    --cc=jeff@garzik.org \
    --cc=linas@austin.ibm.com \
    --cc=linux-ide@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@atrey.karlin.mff.cuni.cz \
    --cc=mchan@broadcom.com \
    --cc=shane.huang@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).