From: Andrew Morton <akpm@linux-foundation.org>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: jeff@garzik.org, linux-ide@vger.kernel.org
Subject: Re: [PATCH] libata/pata_it821x: Improve handling of poorly compatible emulations
Date: Thu, 25 Oct 2007 13:11:05 -0700 [thread overview]
Message-ID: <20071025131105.ca992a64.akpm@linux-foundation.org> (raw)
In-Reply-To: <20071025142116.7e38ee86@the-village.bc.nu>
On Thu, 25 Oct 2007 14:21:16 +0100
Alan Cox <alan@lxorguk.ukuu.org.uk> wrote:
> + if (print_info) {
> + ata_dev_printk(dev, KERN_WARNING,
> +"Drive reports diagnostics failure. This may indicate a drive\n");
> + ata_dev_printk(dev, KERN_WARNING,
> +"fault or invalid emulation. Contact drive vendor for information.\n");
> + }
eww, my eyes.
It would be better to remove the first \n and use KERN_CONT in the second
printk. Maybe. Even better would be to do it all in one printk so that
it is atomic in the printk buffer.
But you probably have more important things to be thinking about ;)
next prev parent reply other threads:[~2007-10-25 20:11 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-25 13:21 [PATCH] libata/pata_it821x: Improve handling of poorly compatible emulations Alan Cox
2007-10-25 20:11 ` Andrew Morton [this message]
2007-10-25 22:34 ` Alan Cox
2007-10-30 13:27 ` Jeff Garzik
2007-10-30 13:33 ` Alan Cox
2007-10-30 13:39 ` Jeff Garzik
2007-10-30 13:43 ` Alan Cox
2007-10-30 13:57 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071025131105.ca992a64.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=jeff@garzik.org \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).