From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
To: Andi Kleen <ak@suse.de>
Cc: linux-ide@vger.kernel.org
Subject: Re: [PATCH] Add a global ide=off switch for drivers/ide
Date: Fri, 26 Oct 2007 02:05:50 +0200 [thread overview]
Message-ID: <200710260205.50181.bzolnier@gmail.com> (raw)
In-Reply-To: <200710260122.02663.ak@suse.de>
On Friday 26 October 2007, Andi Kleen wrote:
> On Thursday 25 October 2007 23:07:23 Bartlomiej Zolnierkiewicz wrote:
>
> > On Monday 15 October 2007, Andi Kleen wrote:
> > >
> > > Had a situation where drivers/ide was compiled in, but I wanted to turn
> > > it off to let the drivers/ata drivers take over. I ended up using ide*=noprobe,
> > > but that was somewhat clumpsy because I wasn't sure how many IDE interfaces
> > > the machine really had.
> > >
> > > Add a global ide=off switch to handle this situation better.
> >
> > Overall looks OK but I think we should limit it to IDE built-in case
> > (when IDE is modular it is all up to the user-space anyway).
>
> Disagree. It's useful for the modular case too e.g. if you
> have the ide modules in your initrd and you want to not load
> them for some reason (e.g. debugging)
This argument sounds rather weak, you may want to not load any other
modules from your inird and you don't add "module=off" to them. :)
Besides the patch in the current form is buggy for the modular IDE
since __ide_pci_register_driver() is valid only when IDE is built-in
(please see how ide_pci_register_driver() is defined in ide.h) and
the patch depends on it to handle "ide=off" for IDE PCI host drivers.
[ No hard feelings wrt modular IDE support if the above issue gets fixed. ]
> > This way we don't pollute device/host drivers with CONFIG_BLK_DEV_IDE #ifdefs.
>
> What CONFIG_BLK_DEV_IDE ifdefs? I added the check only to code that is already
> conditional to this I believe and there were no additional ifdefs at all.
I meant the case if we made "ide=off" valid only for built-in IDE
(then simply referencing ide_off in device/host drivers is incorrect
since ide_off is covered by CONFIG_BLK_DEV_IDE #ifdef/#endif).
Thanks,
Bart
prev parent reply other threads:[~2007-10-26 0:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-15 10:43 [PATCH] Add a global ide=off switch for drivers/ide Andi Kleen
2007-10-25 21:07 ` Bartlomiej Zolnierkiewicz
2007-10-25 23:22 ` Andi Kleen
2007-10-26 0:05 ` Bartlomiej Zolnierkiewicz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200710260205.50181.bzolnier@gmail.com \
--to=bzolnier@gmail.com \
--cc=ak@suse.de \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).