From: Greg KH <greg@kroah.com>
To: Tejun Heo <htejun@gmail.com>
Cc: Jeff Garzik <jeff@garzik.org>,
linux-ide@vger.kernel.org, stable@kernel.org
Subject: Re: [stable] [PATCH 1/2] libata: backport ATA_FLAG_NO_SRST and ATA_FLAG_ASSUME_ATA
Date: Thu, 25 Oct 2007 21:36:28 -0700 [thread overview]
Message-ID: <20071026043628.GB22548@kroah.com> (raw)
In-Reply-To: <47204761.3030500@gmail.com>
On Thu, Oct 25, 2007 at 04:36:01PM +0900, Tejun Heo wrote:
> Jeff Garzik wrote:
> > Tejun Heo wrote:
> >> Backport ATA_FLAG_NO_SRST and ATA_FLAG_ASSUME_ATA. These are
> >> originally link flags (ATA_LFLAG_*) but link abstraction doesn't exist
> >> on 2.6.23, so make it port flags.
> >>
> >> This is for the following workaround for ASUS P5W DH Deluxe.
> >>
> >> These new flags don't introduce any behavior change unless set and
> >> nobody sets them yet.
> >>
> >> Signed-off-by: Tejun Heo <htejun@gmail.com>
> >> ---
> >> This and the next patch are a bit large for -stable but they don't
> >> change anything for machines other than P5W DH and P5W DH users have
> >> been suffering long enough, so I think it'll be nice to include these
> >> patches in the next -stable release. However, feel free to NACK if
> >> you can see some danger in these patches.
> >>
> >> Jeff, what do you think?
> >>
> >> drivers/ata/libata-eh.c | 32 ++++++++++++++++++++++++--------
> >> include/linux/libata.h | 2 ++
> >> 2 files changed, 26 insertions(+), 8 deletions(-)
> >
> > ACK from me, though I wonder if we shouldn't wait and get feedback once
> > this hits upstream (my next push to Andrew and Linus), before applying
> > to stable. No special reason, just being conservative...
>
> Agreed. Let's give the upstream changes a few weeks before updating
> -stable. I'll ping this thread after a few weeks.
Ok, thanks, I'll hold off until you respond.
greg k-h
prev parent reply other threads:[~2007-10-26 4:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-25 6:51 [PATCH 1/2] libata: backport ATA_FLAG_NO_SRST and ATA_FLAG_ASSUME_ATA Tejun Heo
2007-10-25 6:53 ` [PATCH 2/2 -stable] " Tejun Heo
2007-10-25 7:22 ` [PATCH 1/2] " Jeff Garzik
2007-10-25 7:36 ` Tejun Heo
2007-10-26 4:36 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071026043628.GB22548@kroah.com \
--to=greg@kroah.com \
--cc=htejun@gmail.com \
--cc=jeff@garzik.org \
--cc=linux-ide@vger.kernel.org \
--cc=stable@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).