From: Tejun Heo <htejun@gmail.com>
To: Jeff Garzik <jeff@garzik.org>, linux-ide@vger.kernel.org
Cc: ballen@gravity.phys.uwm.edu
Subject: [PATCH 1/3] libata: flush is an IO command
Date: Fri, 26 Oct 2007 15:53:59 +0900 [thread overview]
Message-ID: <20071026065359.GL11853@htj.dyndns.org> (raw)
ATA_QCFLAG_IO is used to mark commands which are used to perform
regluar IO transfers via block layer. These commands are assumed to
be valid and taken more seriously during error handling. Cache flush
is used by regular IO path and necessary for data integrity. Mark it
with ATA_QCFLAG_IO.
Signed-off-by: Tejun Heo <htejun@gmail.com>
---
drivers/ata/libata-scsi.c | 3 +++
1 file changed, 3 insertions(+)
Index: work/drivers/ata/libata-scsi.c
===================================================================
--- work.orig/drivers/ata/libata-scsi.c
+++ work/drivers/ata/libata-scsi.c
@@ -1040,6 +1040,9 @@ static unsigned int ata_scsi_flush_xlat(
else
tf->command = ATA_CMD_FLUSH;
+ /* flush is critical for IO integrity, consider it an IO command */
+ qc->flags |= ATA_QCFLAG_IO;
+
return 0;
}
next reply other threads:[~2007-10-26 6:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-26 6:53 Tejun Heo [this message]
2007-10-26 7:12 ` [PATCH 2/3] libata: stop being overjealous about non-IO commands Tejun Heo
2007-10-26 7:19 ` [PATCH 3/3] libata: implement and use ATA_QCFLAG_QUIET Tejun Heo
2007-10-30 13:32 ` [PATCH 1/3] libata: flush is an IO command Jeff Garzik
2007-10-30 13:52 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071026065359.GL11853@htj.dyndns.org \
--to=htejun@gmail.com \
--cc=ballen@gravity.phys.uwm.edu \
--cc=jeff@garzik.org \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).