From: Ralf Baechle <ralf@linux-mips.org>
To: Denys Vlasenko <vda.linux@googlemail.com>
Cc: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org, linux-ide@vger.kernel.org,
linux-mips@linux-mips.org,
Martijn Uffing <mp3project@sarijopen.student.utwente.nl>
Subject: Re: [IDE] Fix build bug
Date: Tue, 30 Oct 2007 12:41:55 +0000 [thread overview]
Message-ID: <20071030124155.GA7582@linux-mips.org> (raw)
In-Reply-To: <200710301134.30087.vda.linux@googlemail.com>
On Tue, Oct 30, 2007 at 11:34:29AM +0000, Denys Vlasenko wrote:
> On Thursday 25 October 2007 22:41, Bartlomiej Zolnierkiewicz wrote:
> > > -static const struct ide_port_info generic_chipsets[] __devinitdata = {
> > > +static struct ide_port_info generic_chipsets[] __devinitdata = {
> > > /* 0 */ DECLARE_GENERIC_PCI_DEV("Unknown", 0),
> > >
> > > { /* 1 */
> >
> > I would prefer to not remove const from generic_chipsets[] so:
> >
> > [PATCH] drivers/ide/pci/generic: fix build for CONFIG_HOTPLUG=n
> >
> > It turns out that const and __{dev}initdata cannot be mixed currently
> > and that generic IDE PCI host driver is also affected by the same issue:
> >
> > On Thursday 25 October 2007, Ralf Baechle wrote:
> > > CC drivers/ide/pci/generic.o
> > > drivers/ide/pci/generic.c:52: error: __setup_str_ide_generic_all_on causes a
> > > +section type conflict
> >
> > [ Also reported by Martijn Uffing <mp3project@sarijopen.student.utwente.nl>. ]
> >
> > This patch workarounds the problem in a bit hackish way but without
> > removing const from generic_chipsets[] (it adds const to __setup() so
> > __setup_str_ide_generic_all becomes const).
>
> You wouldn't believe how much const data is not marked as const because
> we don't have __constinitdata etc. Literally megabytes.
The gain from marking it const is very little and once any non-const
__initdata object is added to a compilation unit all other const declarations
will have to be removed. Bad tradeoff.
Ralf
next prev parent reply other threads:[~2007-10-30 12:42 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-25 13:53 [IDE] Fix build bug Ralf Baechle
2007-10-25 14:13 ` Sam Ravnborg
2007-10-25 14:13 ` Ralf Baechle
2007-10-25 14:47 ` Maciej W. Rozycki
2007-10-25 16:05 ` Ralf Baechle
2007-10-25 17:12 ` Maciej W. Rozycki
2007-10-25 21:52 ` Bartlomiej Zolnierkiewicz
2007-10-25 21:41 ` Bartlomiej Zolnierkiewicz
2007-10-30 11:34 ` Denys Vlasenko
2007-10-30 12:41 ` Ralf Baechle [this message]
2007-10-30 20:30 ` Bartlomiej Zolnierkiewicz
2007-11-01 18:43 ` Denys Vlasenko
2007-11-02 12:34 ` Ralf Baechle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071030124155.GA7582@linux-mips.org \
--to=ralf@linux-mips.org \
--cc=akpm@linux-foundation.org \
--cc=bzolnier@gmail.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=mp3project@sarijopen.student.utwente.nl \
--cc=vda.linux@googlemail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).