From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ralf Baechle Subject: Re: [IDE] Fix build bug Date: Tue, 30 Oct 2007 12:41:55 +0000 Message-ID: <20071030124155.GA7582@linux-mips.org> References: <20071025135334.GA23272@linux-mips.org> <200710252341.38902.bzolnier@gmail.com> <200710301134.30087.vda.linux@googlemail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from ftp.linux-mips.org ([194.74.144.162]:47396 "EHLO ftp.linux-mips.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751053AbXJ3MmF (ORCPT ); Tue, 30 Oct 2007 08:42:05 -0400 Received: from localhost.localdomain ([127.0.0.1]:6102 "EHLO dl5rb.ham-radio-op.net") by ftp.linux-mips.org with ESMTP id S20024136AbXJ3MmE (ORCPT + 1 other); Tue, 30 Oct 2007 12:42:04 +0000 Content-Disposition: inline In-Reply-To: <200710301134.30087.vda.linux@googlemail.com> Sender: linux-ide-owner@vger.kernel.org List-Id: linux-ide@vger.kernel.org To: Denys Vlasenko Cc: Bartlomiej Zolnierkiewicz , Andrew Morton , linux-kernel@vger.kernel.org, linux-ide@vger.kernel.org, linux-mips@linux-mips.org, Martijn Uffing On Tue, Oct 30, 2007 at 11:34:29AM +0000, Denys Vlasenko wrote: > On Thursday 25 October 2007 22:41, Bartlomiej Zolnierkiewicz wrote: > > > -static const struct ide_port_info generic_chipsets[] __devinitdata = { > > > +static struct ide_port_info generic_chipsets[] __devinitdata = { > > > /* 0 */ DECLARE_GENERIC_PCI_DEV("Unknown", 0), > > > > > > { /* 1 */ > > > > I would prefer to not remove const from generic_chipsets[] so: > > > > [PATCH] drivers/ide/pci/generic: fix build for CONFIG_HOTPLUG=n > > > > It turns out that const and __{dev}initdata cannot be mixed currently > > and that generic IDE PCI host driver is also affected by the same issue: > > > > On Thursday 25 October 2007, Ralf Baechle wrote: > > > CC drivers/ide/pci/generic.o > > > drivers/ide/pci/generic.c:52: error: __setup_str_ide_generic_all_on causes a > > > +section type conflict > > > > [ Also reported by Martijn Uffing . ] > > > > This patch workarounds the problem in a bit hackish way but without > > removing const from generic_chipsets[] (it adds const to __setup() so > > __setup_str_ide_generic_all becomes const). > > You wouldn't believe how much const data is not marked as const because > we don't have __constinitdata etc. Literally megabytes. The gain from marking it const is very little and once any non-const __initdata object is added to a compilation unit all other const declarations will have to be removed. Bad tradeoff. Ralf