linux-ide.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 7/13] icside: add ide_toggle_bounce() calls
@ 2007-11-12 23:01 Bartlomiej Zolnierkiewicz
  2007-11-13 11:21 ` Sergei Shtylyov
  0 siblings, 1 reply; 2+ messages in thread
From: Bartlomiej Zolnierkiewicz @ 2007-11-12 23:01 UTC (permalink / raw)
  To: linux-ide; +Cc: Russell King


Add ide_toggle_bounce() call to ->ide_dma_on/->dma_off_quietly
methods so they match generic __ide_dma_on()/ide_dma_off_quietly().

Since there is no PCI device there should be no functionality
changes caused by this patch.

Cc: Russell King <rmk@arm.linux.org.uk>
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
---
 drivers/ide/arm/icside.c |    2 ++
 1 file changed, 2 insertions(+)

Index: b/drivers/ide/arm/icside.c
===================================================================
--- a/drivers/ide/arm/icside.c
+++ b/drivers/ide/arm/icside.c
@@ -294,6 +294,7 @@ static void icside_dma_host_off(ide_driv
 static void icside_dma_off_quietly(ide_drive_t *drive)
 {
 	drive->using_dma = 0;
+	ide_toggle_bounce(drive, 0);
 }
 
 static void icside_dma_host_on(ide_drive_t *drive)
@@ -303,6 +304,7 @@ static void icside_dma_host_on(ide_drive
 static int icside_dma_on(ide_drive_t *drive)
 {
 	drive->using_dma = 1;
+	ide_toggle_bounce(drive, 1);
 
 	return 0;
 }

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH 7/13] icside: add ide_toggle_bounce() calls
  2007-11-12 23:01 [PATCH 7/13] icside: add ide_toggle_bounce() calls Bartlomiej Zolnierkiewicz
@ 2007-11-13 11:21 ` Sergei Shtylyov
  0 siblings, 0 replies; 2+ messages in thread
From: Sergei Shtylyov @ 2007-11-13 11:21 UTC (permalink / raw)
  To: Bartlomiej Zolnierkiewicz; +Cc: linux-ide, Russell King

Bartlomiej Zolnierkiewicz wrote:

> Add ide_toggle_bounce() call to ->ide_dma_on/->dma_off_quietly
> methods so they match generic __ide_dma_on()/ide_dma_off_quietly().

> Since there is no PCI device there should be no functionality
> changes caused by this patch.

> Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>

Acked-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>

MBR, Sergei

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2007-11-13 11:20 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-11-12 23:01 [PATCH 7/13] icside: add ide_toggle_bounce() calls Bartlomiej Zolnierkiewicz
2007-11-13 11:21 ` Sergei Shtylyov

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).