From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
To: Sergei Shtylyov <sshtylyov@ru.mvista.com>
Cc: linux-ide@vger.kernel.org
Subject: Re: [PATCH 1/13] serverworks: cleanup ->set_dma_mode method
Date: Tue, 13 Nov 2007 22:26:45 +0100 [thread overview]
Message-ID: <200711132226.45742.bzolnier@gmail.com> (raw)
In-Reply-To: <47398B65.7090409@ru.mvista.com>
On Tuesday 13 November 2007, Sergei Shtylyov wrote:
[...]
> > Index: b/drivers/ide/pci/serverworks.c
> > ===================================================================
> > --- a/drivers/ide/pci/serverworks.c
> > +++ b/drivers/ide/pci/serverworks.c
> > @@ -164,25 +164,12 @@ static void svwks_set_dma_mode(ide_drive
> > ultra_timing &= ~(0x0F << (4*unit));
> > ultra_enable &= ~(0x01 << drive->dn);
> >
> > - switch(speed) {
> > - case XFER_MW_DMA_2:
> > - case XFER_MW_DMA_1:
> > - case XFER_MW_DMA_0:
> > - dma_timing |= dma_modes[speed - XFER_MW_DMA_0];
> > - break;
> > -
> > - case XFER_UDMA_5:
> > - case XFER_UDMA_4:
> > - case XFER_UDMA_3:
> > - case XFER_UDMA_2:
> > - case XFER_UDMA_1:
> > - case XFER_UDMA_0:
> > - dma_timing |= dma_modes[2];
>
> Why it needs to change in the first place?
Indeed, there is a needless coupling of MWDMA/UDMA timings in serverworks.
Care to fix it?
Bart
prev parent reply other threads:[~2007-11-13 21:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-12 23:01 [PATCH 1/13] serverworks: cleanup ->set_dma_mode method Bartlomiej Zolnierkiewicz
2007-11-13 11:32 ` Sergei Shtylyov
2007-11-13 21:26 ` Bartlomiej Zolnierkiewicz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200711132226.45742.bzolnier@gmail.com \
--to=bzolnier@gmail.com \
--cc=linux-ide@vger.kernel.org \
--cc=sshtylyov@ru.mvista.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).