From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
To: Sergei Shtylyov <sshtylyov@ru.mvista.com>
Cc: linux-ide@vger.kernel.org
Subject: Re: [PATCH 12/13] ide: move drive->using_dma check to callers of ->dma_host_on method
Date: Tue, 13 Nov 2007 22:27:19 +0100 [thread overview]
Message-ID: <200711132227.19689.bzolnier@gmail.com> (raw)
In-Reply-To: <47398934.8030100@ru.mvista.com>
On Tuesday 13 November 2007, Sergei Shtylyov wrote:
> Bartlomiej Zolnierkiewicz wrote:
>
> > Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
>
> Acked-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>
>
> MBR, Sergei
>
> > Index: b/drivers/ide/ide-dma.c
> > ===================================================================
> > --- a/drivers/ide/ide-dma.c
> > +++ b/drivers/ide/ide-dma.c
> > @@ -470,7 +470,7 @@ EXPORT_SYMBOL(ide_dma_off);
> >
> > void ide_dma_host_on(ide_drive_t *drive)
> > {
> > - if (drive->using_dma) {
> > + if (1) {
>
> Why so?
Just not to move the code around (because it "vanishes" in patch #13/13).
> > ide_hwif_t *hwif = HWIF(drive);
> > u8 unit = (drive->select.b.unit & 0x01);
> > u8 dma_stat = hwif->INB(hwif->dma_status);
prev parent reply other threads:[~2007-11-13 21:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-12 23:02 [PATCH 12/13] ide: move drive->using_dma check to callers of ->dma_host_on method Bartlomiej Zolnierkiewicz
2007-11-13 11:23 ` Sergei Shtylyov
2007-11-13 21:27 ` Bartlomiej Zolnierkiewicz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200711132227.19689.bzolnier@gmail.com \
--to=bzolnier@gmail.com \
--cc=linux-ide@vger.kernel.org \
--cc=sshtylyov@ru.mvista.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).