* [PATCH 6/13] sgiioc4: add ide_toggle_bounce() calls
@ 2007-11-12 23:01 Bartlomiej Zolnierkiewicz
2007-11-13 11:20 ` Sergei Shtylyov
0 siblings, 1 reply; 4+ messages in thread
From: Bartlomiej Zolnierkiewicz @ 2007-11-12 23:01 UTC (permalink / raw)
To: linux-ide; +Cc: Jeremy Higdon
Add ide_toggle_bounce() call to ->ide_dma_on/->dma_off_quietly
methods so they match generic __ide_dma_on()/ide_dma_off_quietly().
Cc: Jeremy Higdon <jeremy@sgi.com>
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
---
drivers/ide/pci/sgiioc4.c | 2 ++
1 file changed, 2 insertions(+)
Index: b/drivers/ide/pci/sgiioc4.c
===================================================================
--- a/drivers/ide/pci/sgiioc4.c
+++ b/drivers/ide/pci/sgiioc4.c
@@ -281,6 +281,7 @@ static int
sgiioc4_ide_dma_on(ide_drive_t * drive)
{
drive->using_dma = 1;
+ ide_toggle_bounce(drive, 1);
return 0;
}
@@ -288,6 +289,7 @@ sgiioc4_ide_dma_on(ide_drive_t * drive)
static void sgiioc4_dma_off_quietly(ide_drive_t *drive)
{
drive->using_dma = 0;
+ ide_toggle_bounce(drive, 0);
drive->hwif->dma_host_off(drive);
}
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH 6/13] sgiioc4: add ide_toggle_bounce() calls
2007-11-12 23:01 [PATCH 6/13] sgiioc4: add ide_toggle_bounce() calls Bartlomiej Zolnierkiewicz
@ 2007-11-13 11:20 ` Sergei Shtylyov
2007-11-16 7:27 ` Jeremy Higdon
0 siblings, 1 reply; 4+ messages in thread
From: Sergei Shtylyov @ 2007-11-13 11:20 UTC (permalink / raw)
To: Bartlomiej Zolnierkiewicz; +Cc: linux-ide, Jeremy Higdon
Bartlomiej Zolnierkiewicz wrote:
> Add ide_toggle_bounce() call to ->ide_dma_on/->dma_off_quietly
> methods so they match generic __ide_dma_on()/ide_dma_off_quietly().
> Cc: Jeremy Higdon <jeremy@sgi.com>
> Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Acked-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>
MBR, Sergei
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 6/13] sgiioc4: add ide_toggle_bounce() calls
2007-11-13 11:20 ` Sergei Shtylyov
@ 2007-11-16 7:27 ` Jeremy Higdon
2007-11-16 20:33 ` Bartlomiej Zolnierkiewicz
0 siblings, 1 reply; 4+ messages in thread
From: Jeremy Higdon @ 2007-11-16 7:27 UTC (permalink / raw)
To: Sergei Shtylyov; +Cc: Bartlomiej Zolnierkiewicz, linux-ide
On Tue, Nov 13, 2007 at 02:20:02PM +0300, Sergei Shtylyov wrote:
> Bartlomiej Zolnierkiewicz wrote:
>
> >Add ide_toggle_bounce() call to ->ide_dma_on/->dma_off_quietly
> >methods so they match generic __ide_dma_on()/ide_dma_off_quietly().
>
> >Cc: Jeremy Higdon <jeremy@sgi.com>
> >Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
>
> Acked-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>
Tested on an Altix.
Acked-by: Jeremy Higdon <jeremy@sgi.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 6/13] sgiioc4: add ide_toggle_bounce() calls
2007-11-16 7:27 ` Jeremy Higdon
@ 2007-11-16 20:33 ` Bartlomiej Zolnierkiewicz
0 siblings, 0 replies; 4+ messages in thread
From: Bartlomiej Zolnierkiewicz @ 2007-11-16 20:33 UTC (permalink / raw)
To: Jeremy Higdon; +Cc: Sergei Shtylyov, linux-ide
On Friday 16 November 2007, Jeremy Higdon wrote:
> On Tue, Nov 13, 2007 at 02:20:02PM +0300, Sergei Shtylyov wrote:
> > Bartlomiej Zolnierkiewicz wrote:
> >
> > >Add ide_toggle_bounce() call to ->ide_dma_on/->dma_off_quietly
> > >methods so they match generic __ide_dma_on()/ide_dma_off_quietly().
> >
> > >Cc: Jeremy Higdon <jeremy@sgi.com>
> > >Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
> >
> > Acked-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>
>
> Tested on an Altix.
Thanks!
> Acked-by: Jeremy Higdon <jeremy@sgi.com>
added to patch description
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2007-11-16 21:31 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-11-12 23:01 [PATCH 6/13] sgiioc4: add ide_toggle_bounce() calls Bartlomiej Zolnierkiewicz
2007-11-13 11:20 ` Sergei Shtylyov
2007-11-16 7:27 ` Jeremy Higdon
2007-11-16 20:33 ` Bartlomiej Zolnierkiewicz
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).