From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
To: Jonas Stare <jonas.stare@purplescout.se>
Cc: Andrew Morton <akpm@linux-foundation.org>,
torvalds@linux-foundation.org, linux-kernel@vger.kernel.org,
Alan Cox <alan@lxorguk.ukuu.org.uk>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
linux-ide@vger.kernel.org
Subject: Re: [PATCH] drivers/ide/ide-probe.c Skip ide_wait_not_busy on noprobe-disks. was: [PATCH][RESUBMIT] drivers/ide/ide-probe.c, kernel 2.6.23.1
Date: Sun, 18 Nov 2007 22:39:33 +0100 [thread overview]
Message-ID: <200711182239.33274.bzolnier@gmail.com> (raw)
In-Reply-To: <473E2049.4070806@purplescout.se>
On Friday 16 November 2007, Jonas Stare wrote:
> There is a problem in some hardware where the kernel will stall for
> 35 seconds waiting for disks that dont exist. This patch will skip
> waiting for the BSY-bit on ide-drives to go away if you set
> hdx=noprobe as a kernel option and the disk is not marked
> as 'present' (like when you set the geometry by hand).
>
> If no noprobe-option is set the code will work (more or less) as the
> original but if set the code will skip the ide_wait_not_busy() for that
> drive. Even if there would be a drive there and it is still BSY
> afterwards it should not matter since it isn't probed for later.
>
> (The code also honors the MAX_DRIVES variable instead of assuming that
> there will be two harddrives on the bus.)
>
>
> Signed-off-by: Jonas Stare <jonas.stare@purplescout.se>
Thanks!
PS There were still some whitespace problems (all tabs were replaced by
spaces) so I just applied it by hand (and made few minor cleanups while
at it).
Bart
prev parent reply other threads:[~2007-11-18 21:40 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <473434F1.50509@purplescout.se>
[not found] ` <20071112132448.0facce12.akpm@linux-foundation.org>
[not found] ` <200711132303.28424.bzolnier@gmail.com>
2007-11-15 8:52 ` [PATCH] drivers/ide/ide-probe.c, kernel 2.6.23.1 Jonas Stare
2007-11-15 20:59 ` Bartlomiej Zolnierkiewicz
2007-11-16 12:10 ` [PATCH][RESUBMIT] " Jonas Stare
2007-11-16 12:51 ` Sergei Shtylyov
2007-11-16 17:46 ` Jonas Stare
2007-11-16 21:22 ` Bartlomiej Zolnierkiewicz
2007-11-16 22:57 ` [PATCH] drivers/ide/ide-probe.c Skip ide_wait_not_busy on noprobe-disks. was: " Jonas Stare
2007-11-18 21:39 ` Bartlomiej Zolnierkiewicz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200711182239.33274.bzolnier@gmail.com \
--to=bzolnier@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=benh@kernel.crashing.org \
--cc=jonas.stare@purplescout.se \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).