[PATCH] pata_platform: move ARCH_RPC to use MACH_HAS_PATA_PLATFORM

[PATCH] pata_platform: move ARCH_RPC to use MACH_HAS_PATA_PLATFORM

[Ben Dooks]

[-- Attachment #1: Type: text/plain, Size: 1421 bytes --]

Move ARCH_RPC to using MACH_HAS_PATA_PLATFORM as an example
of using this new configuration.

Signed-off-by: Ben Dooks <ben-linux@fluff.org>

diff -urpN -X linux-2.6.24-rc3-pata1/Documentation/dontdiff linux-2.6.24-rc3-pata1/drivers/ata/Kconfig linux-2.6.24-rc3-pata2/drivers/ata/Kconfig
--- linux-2.6.24-rc3-pata1/drivers/ata/Kconfig	2007-11-19 12:25:03.000000000 +0000
+++ linux-2.6.24-rc3-pata2/drivers/ata/Kconfig	2007-11-19 12:24:51.000000000 +0000
@@ -570,7 +570,7 @@ config MACH_HAS_PATA_PLATFORM
 
 config PATA_PLATFORM
 	tristate "Generic platform device PATA support"
-	depends on EMBEDDED || ARCH_RPC || MACH_HAS_PATA_PLATFORM
+	depends on EMBEDDED || MACH_HAS_PATA_PLATFORM
 	help
 	  This option enables support for generic directly connected ATA
 	  devices commonly found on embedded systems.
diff -urpN -X linux-2.6.24-rc3-pata1/Documentation/dontdiff linux-2.6.24-rc3-pata1/arch/arm/Kconfig linux-2.6.24-rc3-pata2/arch/arm/Kconfig
--- linux-2.6.24-rc3-pata1/arch/arm/Kconfig	2007-10-09 21:31:38.000000000 +0100
+++ linux-2.6.24-rc3-pata2/arch/arm/Kconfig	2007-11-19 12:25:43.000000000 +0000
@@ -353,6 +353,7 @@ config ARCH_RPC
 	select ARCH_MAY_HAVE_PC_FDC
 	select ISA_DMA_API
 	select NO_IOPORT
+	select MACH_HAS_PATA_PLATFORM
 	help
 	  On the Acorn Risc-PC, Linux can support the internal IDE disk and
 	  CD-ROM interface, serial and parallel port, and the floppy drive.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 189 bytes --]

Re: [PATCH] pata_platform: move ARCH_RPC to use MACH_HAS_PATA_PLATFORM

[Russell King - ARM Linux]

On Mon, Nov 19, 2007 at 12:43:40PM +0000, Ben Dooks wrote:
> Move ARCH_RPC to using MACH_HAS_PATA_PLATFORM as an example
> of using this new configuration.

I thought that it had been agreed (on linux-arch) that the name of these
options shall be HAVE_foo to enable a driver configuration symbol of
foo.

IOW, this should be HAVE_PATA_PLATFORM not MACH_HAS_PATA_PLATFORM.

(Not sure who introduced MACH_HAS_xxx but added Sam and Mathieu
since they were involved in the discussion over HAVE_xxx.)

Re: [PATCH] pata_platform: move ARCH_RPC to use MACH_HAS_PATA_PLATFORM

[Ben Dooks]

On Mon, Nov 19, 2007 at 12:50:15PM +0000, Russell King - ARM Linux wrote:
> On Mon, Nov 19, 2007 at 12:43:40PM +0000, Ben Dooks wrote:
> > Move ARCH_RPC to using MACH_HAS_PATA_PLATFORM as an example
> > of using this new configuration.
> 
> I thought that it had been agreed (on linux-arch) that the name of these
> options shall be HAVE_foo to enable a driver configuration symbol of
> foo.
> 
> IOW, this should be HAVE_PATA_PLATFORM not MACH_HAS_PATA_PLATFORM.

Ok, HAVE_PATA_PLATFORM should be unique enough without adding anything
like HAVE_DRIVER_PATA_PLATFORM. If no-one else objects, I will submit
a new version of these two patches.

-- 
Ben

Q:      What's a light-year?
A:      One-third less calories than a regular year.