From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matthew Wilcox Subject: Re: [PATCH 2/2] ide-scsi: use print_hex_dump from Date: Mon, 26 Nov 2007 06:25:13 -0700 Message-ID: <20071126132513.GA3230@parisc-linux.org> References: <1196061373-6394-1-git-send-email-crquan@gmail.com> <1196062867.8948.25.camel@localhost> <91b13c310711260037o7af4b11dt389bb209a075c25a@mail.gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from palinux.external.hp.com ([192.25.206.14]:39045 "EHLO mail.parisc-linux.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752862AbXKZNZR (ORCPT ); Mon, 26 Nov 2007 08:25:17 -0500 Content-Disposition: inline In-Reply-To: <91b13c310711260037o7af4b11dt389bb209a075c25a@mail.gmail.com> Sender: linux-ide-owner@vger.kernel.org List-Id: linux-ide@vger.kernel.org To: rae l Cc: Joe Perches , linux-ide@vger.kernel.org, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, Randy Dunlap On Mon, Nov 26, 2007 at 04:37:50PM +0800, rae l wrote: > I know this is different from the original hexdump in ide-scsi.c, I > just want to tell someone that there's a good implementation of > hexdump in kernel.h, and I think the default KERN_DEBUG and > print_hex_dump is more informative and has better output. However, > anyone want more precise control on debug message could make her/his > improvements with print_hex_dump. using KERN_DEBUG is wrong -- this is part of a line, so you need to use KERN_NONE or simply "". -- Intel are signing my paycheques ... these opinions are still mine "Bill, look, we understand that you're interested in selling us this operating system, but compare it to ours. We can't possibly take such a retrograde step."