[PATCH 1/6] au1xxx-ide: au_ide_probe() fixes

[PATCH 1/6] au1xxx-ide: au_ide_probe() fixes

[Bartlomiej Zolnierkiewicz]

* hwif->hold is always set in au_ide_probe() (few lines earlier),
  no need to set it again

* hwif->{channel,select_data,config_data} should be always zero

* autotune PIO also if CONFIG_BLK_DEV_IDE_AU1XXX_MDMA2_BDMA is not defined

Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
---
 drivers/ide/mips/au1xxx-ide.c |    5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

Index: b/drivers/ide/mips/au1xxx-ide.c
===================================================================
--- a/drivers/ide/mips/au1xxx-ide.c
+++ b/drivers/ide/mips/au1xxx-ide.c
@@ -677,15 +677,14 @@ static int au_ide_probe(struct device *d
 	hwif->dma_setup                 = &auide_dma_setup;
 	hwif->ide_dma_test_irq          = &auide_dma_test_irq;
 	hwif->dma_lost_irq		= &auide_dma_lost_irq;
-#else /* !CONFIG_BLK_DEV_IDE_AU1XXX_MDMA2_DBDMA */
+#endif
 	hwif->channel                   = 0;
-	hwif->hold                      = 1;
 	hwif->select_data               = 0;    /* no chipset-specific code */
 	hwif->config_data               = 0;    /* no chipset-specific code */
 
 	hwif->drives[0].autotune        = 1;    /* 1=autotune, 2=noautotune, 0=default */
 	hwif->drives[1].autotune	= 1;
-#endif
+
 	hwif->drives[0].no_io_32bit	= 1;
 	hwif->drives[1].no_io_32bit	= 1;
 

Re: [PATCH 1/6] au1xxx-ide: au_ide_probe() fixes

[Sergei Shtylyov]

Bartlomiej Zolnierkiewicz wrote:

> * hwif->hold is always set in au_ide_probe() (few lines earlier),
>   no need to set it again

> * hwif->{channel,select_data,config_data} should be always zero

> * autotune PIO also if CONFIG_BLK_DEV_IDE_AU1XXX_MDMA2_BDMA is not defined

    You mean "also if CONFIG_BLK_DEV_IDE_AU1XXX_MDMA2_DBDMA is defined"?

> Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>

Acked-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>

MBR, Sergei

Re: [PATCH 1/6] au1xxx-ide: au_ide_probe() fixes

[Bartlomiej Zolnierkiewicz]

On Wednesday 28 November 2007, Sergei Shtylyov wrote:
> Bartlomiej Zolnierkiewicz wrote:
> 
> > * hwif->hold is always set in au_ide_probe() (few lines earlier),
> >   no need to set it again
> 
> > * hwif->{channel,select_data,config_data} should be always zero
> 
> > * autotune PIO also if CONFIG_BLK_DEV_IDE_AU1XXX_MDMA2_BDMA is not defined
> 
>     You mean "also if CONFIG_BLK_DEV_IDE_AU1XXX_MDMA2_DBDMA is defined"?

Yes, fixed.

Thanks,
Bart