From mboxrd@z Thu Jan 1 00:00:00 1970 From: Anton Vorontsov Subject: Re: [PATCH 2/3] [libata] pata_of_platform: OF-Platform PATA device driver Date: Fri, 30 Nov 2007 13:58:49 +0300 Message-ID: <20071130105849.GA10840@localhost.localdomain> References: <20071127153708.GA12490@localhost.localdomain> <20071127153908.GB14183@localhost.localdomain> <20071127212222.GB10829@lixom.net> <200711272233.00456.arnd@arndb.de> <20071128154904.GA20722@localhost.localdomain> <474D9327.9020305@ru.mvista.com> <20071129005440.GA2235@zarina> <474FE332.8080103@ru.mvista.com> Reply-To: avorontsov@ru.mvista.com Mime-Version: 1.0 Content-Type: text/plain; charset=utf8 Return-path: Received: from rtsoft3.corbina.net ([85.21.88.6]:15499 "EHLO buildserver.ru.mvista.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1751602AbXK3KyS (ORCPT ); Fri, 30 Nov 2007 05:54:18 -0500 Content-Disposition: inline In-Reply-To: <474FE332.8080103@ru.mvista.com> Sender: linux-ide-owner@vger.kernel.org List-Id: linux-ide@vger.kernel.org To: Sergei Shtylyov Cc: cbou@mail.ru, Olof Johansson , linuxppc-dev@ozlabs.org, Arnd Bergmann , linux-ide@vger.kernel.org On Fri, Nov 30, 2007 at 01:17:22PM +0300, Sergei Shtylyov wrote: > Anton Vorontsov wrote: > > >Remaining question: any preferred name for that property? pio-mode okay? > >It's assuming that PIO6 capable bus supports PIO0 as well, thus no mask. > > I've already suggested "generic". A name "simple" also comes to my mind. You've misread my question. I didn't ask about driver name, but pio-mode property. As for the driver name, it doesn't matter at all, as I've said already: it's Linux specific anyway, and another compatible properties could be added at any time, to a device tree and/or to the OF driver itself (if some real OpenFirmware will pass some meaningful compatible property that we'll have to match in that driver). "generic" name is also bad one, it's confusing wrt ata_generic.c driver (PCI). "simple" name doesn't tell anything at all. So, I'd rather stick with -platform name. Thanks, -- Anton Vorontsov email: cbou@mail.ru backup email: ya-cbou@yandex.ru irc://irc.freenode.net/bd2