From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bartlomiej Zolnierkiewicz Subject: Re: [PATCH 24/28] blk_end_request: changing ide normal caller (take 3) Date: Sat, 1 Dec 2007 23:53:05 +0100 Message-ID: <200712012353.05187.bzolnier@gmail.com> References: <20071130.183358.35360061.k-ueda@ct.jp.nec.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20071130.183358.35360061.k-ueda@ct.jp.nec.com> Content-Disposition: inline Sender: linux-scsi-owner@vger.kernel.org To: Kiyoshi Ueda Cc: jens.axboe@oracle.com, bharrosh@panasas.com, linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org, linux-ide@vger.kernel.org, dm-devel@redhat.com, j-nomura@ce.jp.nec.com List-Id: linux-ide@vger.kernel.org On Saturday 01 December 2007, Kiyoshi Ueda wrote: > This patch converts "normal" parts of ide to use blk_end_request(). > > Signed-off-by: Kiyoshi Ueda > Signed-off-by: Jun'ichi Nomura > --- > drivers/ide/ide-cd.c | 6 +++--- > drivers/ide/ide-io.c | 17 ++++++----------- > 2 files changed, 9 insertions(+), 14 deletions(-) [...] > Index: 2.6.24-rc3-mm2/drivers/ide/ide-io.c > =================================================================== > --- 2.6.24-rc3-mm2.orig/drivers/ide/ide-io.c > +++ 2.6.24-rc3-mm2/drivers/ide/ide-io.c > @@ -78,14 +78,9 @@ static int __ide_end_request(ide_drive_t > ide_dma_on(drive); > } > > - if (!end_that_request_chunk(rq, uptodate, nr_bytes)) { > - add_disk_randomness(rq->rq_disk); > - if (dequeue) { > - if (!list_empty(&rq->queuelist)) > - blkdev_dequeue_request(rq); > + if (!__blk_end_request(rq, uptodate, nr_bytes)) { > + if (dequeue) > HWGROUP(drive)->rq = NULL; > - } > - end_that_request_last(rq, uptodate); > ret = 0; > } Hmmm, this seems to change the old behavior (the request should be dequeued from the queue only if 'dequeue' variable is set) and AFAIR some error handling code (in ide-cd?) depends on the old behavior so please revisit this patch. Thanks, Bart