* [PATCH 14/20] ide: convert "empty" REQ_TYPE_ATA_CMD requests to use REQ_TYPE_ATA_TASKFILE
@ 2007-12-09 21:17 Bartlomiej Zolnierkiewicz
2007-12-13 12:55 ` Sergei Shtylyov
0 siblings, 1 reply; 3+ messages in thread
From: Bartlomiej Zolnierkiewicz @ 2007-12-09 21:17 UTC (permalink / raw)
To: linux-ide; +Cc: Tejun Heo
Based on the previous work by Tejun Heo.
There should be no functionality changes caused by this patch.
Cc: Tejun Heo <htejun@gmail.com>
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
---
drivers/ide/ide-disk.c | 4 +++-
drivers/ide/ide-taskfile.c | 2 +-
drivers/ide/ide.c | 2 +-
3 files changed, 5 insertions(+), 3 deletions(-)
Index: b/drivers/ide/ide-disk.c
===================================================================
--- a/drivers/ide/ide-disk.c
+++ b/drivers/ide/ide-disk.c
@@ -620,8 +620,10 @@ static int set_multcount(ide_drive_t *dr
if (drive->special.b.set_multmode)
return -EBUSY;
+
ide_init_drive_cmd (&rq);
- rq.cmd_type = REQ_TYPE_ATA_CMD;
+ rq.cmd_type = REQ_TYPE_ATA_TASKFILE;
+
drive->mult_req = arg;
drive->special.b.set_multmode = 1;
(void) ide_do_drive_cmd (drive, &rq, ide_wait);
Index: b/drivers/ide/ide-taskfile.c
===================================================================
--- a/drivers/ide/ide-taskfile.c
+++ b/drivers/ide/ide-taskfile.c
@@ -782,7 +782,7 @@ int ide_cmd_ioctl (ide_drive_t *drive, u
struct request rq;
ide_init_drive_cmd(&rq);
- rq.cmd_type = REQ_TYPE_ATA_CMD;
+ rq.cmd_type = REQ_TYPE_ATA_TASKFILE;
return ide_do_drive_cmd(drive, &rq, ide_wait);
}
Index: b/drivers/ide/ide.c
===================================================================
--- a/drivers/ide/ide.c
+++ b/drivers/ide/ide.c
@@ -876,7 +876,7 @@ int set_pio_mode(ide_drive_t *drive, int
return -EBUSY;
ide_init_drive_cmd(&rq);
- rq.cmd_type = REQ_TYPE_ATA_CMD;
+ rq.cmd_type = REQ_TYPE_ATA_TASKFILE;
drive->tune_req = (u8) arg;
drive->special.b.set_tune = 1;
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 14/20] ide: convert "empty" REQ_TYPE_ATA_CMD requests to use REQ_TYPE_ATA_TASKFILE
2007-12-09 21:17 [PATCH 14/20] ide: convert "empty" REQ_TYPE_ATA_CMD requests to use REQ_TYPE_ATA_TASKFILE Bartlomiej Zolnierkiewicz
@ 2007-12-13 12:55 ` Sergei Shtylyov
2007-12-13 13:54 ` Bartlomiej Zolnierkiewicz
0 siblings, 1 reply; 3+ messages in thread
From: Sergei Shtylyov @ 2007-12-13 12:55 UTC (permalink / raw)
To: Bartlomiej Zolnierkiewicz; +Cc: linux-ide, Tejun Heo
Bartlomiej Zolnierkiewicz wrote:
> Based on the previous work by Tejun Heo.
> There should be no functionality changes caused by this patch.
I didn't get the point. Why do you consider them "empty"?
> Cc: Tejun Heo <htejun@gmail.com>
> Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
> Index: b/drivers/ide/ide-disk.c
> ===================================================================
> --- a/drivers/ide/ide-disk.c
> +++ b/drivers/ide/ide-disk.c
> @@ -620,8 +620,10 @@ static int set_multcount(ide_drive_t *dr
>
> if (drive->special.b.set_multmode)
> return -EBUSY;
> +
> ide_init_drive_cmd (&rq);
> - rq.cmd_type = REQ_TYPE_ATA_CMD;
> + rq.cmd_type = REQ_TYPE_ATA_TASKFILE;
> +
> drive->mult_req = arg;
> drive->special.b.set_multmode = 1;
> (void) ide_do_drive_cmd (drive, &rq, ide_wait);
> Index: b/drivers/ide/ide-taskfile.c
> ===================================================================
> --- a/drivers/ide/ide-taskfile.c
> +++ b/drivers/ide/ide-taskfile.c
> @@ -782,7 +782,7 @@ int ide_cmd_ioctl (ide_drive_t *drive, u
> struct request rq;
>
> ide_init_drive_cmd(&rq);
> - rq.cmd_type = REQ_TYPE_ATA_CMD;
> + rq.cmd_type = REQ_TYPE_ATA_TASKFILE;
>
> return ide_do_drive_cmd(drive, &rq, ide_wait);
> }
> Index: b/drivers/ide/ide.c
> ===================================================================
> --- a/drivers/ide/ide.c
> +++ b/drivers/ide/ide.c
> @@ -876,7 +876,7 @@ int set_pio_mode(ide_drive_t *drive, int
> return -EBUSY;
>
> ide_init_drive_cmd(&rq);
> - rq.cmd_type = REQ_TYPE_ATA_CMD;
> + rq.cmd_type = REQ_TYPE_ATA_TASKFILE;
>
> drive->tune_req = (u8) arg;
> drive->special.b.set_tune = 1;
MBR, Sergei
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH 14/20] ide: convert "empty" REQ_TYPE_ATA_CMD requests to use REQ_TYPE_ATA_TASKFILE
2007-12-13 12:55 ` Sergei Shtylyov
@ 2007-12-13 13:54 ` Bartlomiej Zolnierkiewicz
0 siblings, 0 replies; 3+ messages in thread
From: Bartlomiej Zolnierkiewicz @ 2007-12-13 13:54 UTC (permalink / raw)
To: Sergei Shtylyov; +Cc: linux-ide, Tejun Heo
On Thursday 13 December 2007, Sergei Shtylyov wrote:
> Bartlomiej Zolnierkiewicz wrote:
>
> > Based on the previous work by Tejun Heo.
>
> > There should be no functionality changes caused by this patch.
>
> I didn't get the point. Why do you consider them "empty"?
These requests don't have command buffer (in case of REQ_TYPE_ATA_CMD)
or ide_task_t (REQ_ATA_TYPE_ATA_TASKFILE) attached to them.
[ Please see execute_drive_cmd() for details. ]
Bart
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2007-12-13 13:45 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-12-09 21:17 [PATCH 14/20] ide: convert "empty" REQ_TYPE_ATA_CMD requests to use REQ_TYPE_ATA_TASKFILE Bartlomiej Zolnierkiewicz
2007-12-13 12:55 ` Sergei Shtylyov
2007-12-13 13:54 ` Bartlomiej Zolnierkiewicz
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).