* [PATCH 17/20] ide: fix final status check in drive_cmd_intr()
@ 2007-12-09 21:19 Bartlomiej Zolnierkiewicz
2007-12-10 13:44 ` Sergei Shtylyov
0 siblings, 1 reply; 2+ messages in thread
From: Bartlomiej Zolnierkiewicz @ 2007-12-09 21:19 UTC (permalink / raw)
To: linux-ide
Don't check for READY_STAT bit being set for PIO-in protocol (makes the
final status check in drive_cmd_intr() match the one in task_in_intr()).
Also fix function name reported by ide_error() call while at it.
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
---
drivers/ide/ide-io.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
Index: b/drivers/ide/ide-io.c
===================================================================
--- a/drivers/ide/ide-io.c
+++ b/drivers/ide/ide-io.c
@@ -659,8 +659,8 @@ static ide_startstop_t drive_cmd_intr (i
stat = hwif->INB(IDE_STATUS_REG);
}
- if (!OK_STAT(stat, READY_STAT, BAD_STAT))
- return ide_error(drive, "drive_cmd", stat);
+ if (!OK_STAT(stat, (pio_in ? 0 : READY_STAT), BAD_STAT))
+ return ide_error(drive, __FUNCTION__, stat);
/* calls ide_end_drive_cmd */
ide_end_drive_cmd(drive, stat, hwif->INB(IDE_ERROR_REG));
return ide_stopped;
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH 17/20] ide: fix final status check in drive_cmd_intr()
2007-12-09 21:19 [PATCH 17/20] ide: fix final status check in drive_cmd_intr() Bartlomiej Zolnierkiewicz
@ 2007-12-10 13:44 ` Sergei Shtylyov
0 siblings, 0 replies; 2+ messages in thread
From: Sergei Shtylyov @ 2007-12-10 13:44 UTC (permalink / raw)
To: Bartlomiej Zolnierkiewicz; +Cc: linux-ide
Bartlomiej Zolnierkiewicz wrote:
> Don't check for READY_STAT bit being set for PIO-in protocol (makes the
> final status check in drive_cmd_intr() match the one in task_in_intr()).
> Also fix function name reported by ide_error() call while at it.
> Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Acked-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>
MBR, Sergei
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2007-12-10 13:44 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-12-09 21:19 [PATCH 17/20] ide: fix final status check in drive_cmd_intr() Bartlomiej Zolnierkiewicz
2007-12-10 13:44 ` Sergei Shtylyov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).