From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: linux-ide@vger.kernel.org
Subject: Re: [PATCH 3/20] dtc2278: ->io_32bit setting don't have to be identical for master/slave
Date: Mon, 10 Dec 2007 00:15:15 +0100 [thread overview]
Message-ID: <200712100015.15735.bzolnier@gmail.com> (raw)
In-Reply-To: <20071209222736.1c4ba88c@the-village.bc.nu>
On Sunday 09 December 2007, Alan Cox wrote:
> > drive->io_32bit is used per PIO transfer so there is no reason to
> > require it to be identical for master/slave.
>
> Sure about that ?
>
> The driver has always gone to great pains to ensure that occurs and that
> suggests the author had a good reason for doing it. Have you tested this
> with an actual DTC2278 card ?
>
> If not - NAK. You risk corruptors for no material benefit.
There is absolutely no hardware setup done by IDE subsystem or dtc2278
host driver when ->io_32bit setting is changed and since ->io_32bit setting
is only ever checked per drive / PIO transfer so this is currently purely
a software limitation (moreover HDIO_DRIVE_CMD and HDIO_DRIVE_TASKFILE
ioctls force 16-bit I/O anyway).
[ I also haven't noticed anything related to this requirement in Winbond
W83759A datasheet (though I have only quickly skimmed through it)... ]
Bart
next prev parent reply other threads:[~2007-12-09 23:06 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-09 21:08 [PATCH 3/20] dtc2278: ->io_32bit setting don't have to be identical for master/slave Bartlomiej Zolnierkiewicz
2007-12-09 22:27 ` Alan Cox
2007-12-09 23:15 ` Bartlomiej Zolnierkiewicz [this message]
2007-12-09 23:07 ` Alan Cox
2007-12-09 23:52 ` Bartlomiej Zolnierkiewicz
2007-12-10 0:01 ` Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200712100015.15735.bzolnier@gmail.com \
--to=bzolnier@gmail.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).