From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: linux-ide@vger.kernel.org
Subject: Re: [PATCH 3/20] dtc2278: ->io_32bit setting don't have to be identical for master/slave
Date: Mon, 10 Dec 2007 00:52:28 +0100 [thread overview]
Message-ID: <200712100052.28528.bzolnier@gmail.com> (raw)
In-Reply-To: <20071209230736.2cdb6e44@the-village.bc.nu>
On Monday 10 December 2007, Alan Cox wrote:
> > There is absolutely no hardware setup done by IDE subsystem or dtc2278
> > host driver when ->io_32bit setting is changed and since ->io_32bit setting
>
> So ?
>
> The original author went to great trouble to specifically enforce the
> behaviour in question and probably did so for a reason. Would it not be
Probably so but please keep in mind the state of IDE subsystem back
then...
> far safer to fix it by keeping that enforcement and fixing where it is
> lost than removing it - especially if you cannot test the hardware ?
What about just enforcing ->io_32bit for both drives in ->init_hwif method
and disallowing any futher changes with 'hwif->no_io_32bit = 1'?
Thanks,
Bart
next prev parent reply other threads:[~2007-12-09 23:43 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-09 21:08 [PATCH 3/20] dtc2278: ->io_32bit setting don't have to be identical for master/slave Bartlomiej Zolnierkiewicz
2007-12-09 22:27 ` Alan Cox
2007-12-09 23:15 ` Bartlomiej Zolnierkiewicz
2007-12-09 23:07 ` Alan Cox
2007-12-09 23:52 ` Bartlomiej Zolnierkiewicz [this message]
2007-12-10 0:01 ` Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200712100052.28528.bzolnier@gmail.com \
--to=bzolnier@gmail.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).