From mboxrd@z Thu Jan 1 00:00:00 1970 From: Olof Johansson Subject: [PATCH] Fix build break caused by "ide: remove ideprobe_init()" Date: Fri, 14 Dec 2007 03:09:15 -0600 Message-ID: <20071214090915.GA28681@lixom.net> References: <200711182325.09262.bzolnier@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from lixom.net ([66.141.50.11]:33808 "EHLO mail.lixom.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752808AbXLNJDr (ORCPT ); Fri, 14 Dec 2007 04:03:47 -0500 Content-Disposition: inline In-Reply-To: <200711182325.09262.bzolnier@gmail.com> Sender: linux-ide-owner@vger.kernel.org List-Id: linux-ide@vger.kernel.org To: Bartlomiej Zolnierkiewicz Cc: linux-ide@vger.kernel.org, akpm@linux-foundation.org, linuxppc-dev@ozlabs.org Fix build break of powerpc holly_defconfig: In file included from arch/powerpc/platforms/embedded6xx/holly.c:24: include/linux/ide.h:1206: error: 'CONFIG_IDE_MAX_HWIFS' undeclared here (not in a function) There's no need to have a sized array in the prototype, might as well turn it into a pointer. It could probably be argued that large parts of the include file can be covered under #ifdef CONFIG_IDE, but that's a larger undertaking. Signed-off-by: Olof Johansson --- On Sun, Nov 18, 2007 at 11:25:09PM +0100, Bartlomiej Zolnierkiewicz wrote: > > * Rename ide_device_add() to ide_device_add_all() and make it accept > 'u8 idx[MAX_HWIFS]' instead of 'u8 idx[4]' as an argument. > > * Add ide_device_add() wrapper for ide_device_add_all(). > > * Convert ide_generic_init() to use ide_device_add_all(). > > * Remove no longer needed ideprobe_init(). > > There should be no functionality changes caused by this patch. This patch broke builds of powerpc holly_defconfig in -mm. It has CONFIG_EMBEDDED=y, CONFIG_IDE=n but includes linux/ide.h: Index: mm/drivers/ide/ide-probe.c =================================================================== --- mm.orig/drivers/ide/ide-probe.c +++ mm/drivers/ide/ide-probe.c @@ -1335,7 +1335,7 @@ static void hwif_register_devices(ide_hw } } -int ide_device_add_all(u8 idx[MAX_HWIFS]) +int ide_device_add_all(u8 *idx) { ide_hwif_t *hwif; int i, rc = 0; Index: mm/include/linux/ide.h =================================================================== --- mm.orig/include/linux/ide.h +++ mm/include/linux/ide.h @@ -1203,7 +1203,7 @@ void ide_unregister_region(struct gendis void ide_undecoded_slave(ide_drive_t *); -int ide_device_add_all(u8 idx[MAX_HWIFS]); +int ide_device_add_all(u8 *idx); int ide_device_add(u8 idx[4]); static inline void *ide_get_hwifdata (ide_hwif_t * hwif)