[PATCH 0/3] Add GD-Rom support to the SEGA Dreamcast

[PATCH 0/3] Add GD-Rom support to the SEGA Dreamcast

[Adrian McMenamin]

(Apologies if you've already had this. I sent it to lkml etc an hour
ago but it just disappeated into the ether - trying it in smaller
packets this time.)

This patch adds support for the CD drive on the SEGA Dreamcast - the
so-called GD Rom drive.

This device is electrically compatible with ATA-3 IDE CD drives but
implements a proprietary packet interface. There have been previous
Dreamcast CD drivers around but this is new code and uses DMA as
opposed to PIO for reads.

It also supports reading the proprietary GD Rom format disks.

The driver will live as drivers/sh/gdrom/gdrom.c

This has been tested against the latest git in Paul Mundt's 2.6.25
queue as well as 2.6.24-rc5

Signed-off by: Adrian McMenamin <adrian@mcmen.demon.co.uk>

Re: [PATCH 0/3] Add GD-Rom support to the SEGA Dreamcast

[Adrian McMenamin]

On Sun, 2007-12-16 at 00:20 +0000, Adrian McMenamin wrote:
> (Apologies if you've already had this. I sent it to lkml etc an hour
> ago but it just disappeated into the ether - trying it in smaller
> packets this time.)
> 

vger/lkml's spam filtering is trapping the main part of the patch as
spam. Possibly because it has a lot of register names as capitals?

I'll have to find some other way of putting it on the list.

Re: [PATCH 0/3] Add GD-Rom support to the SEGA Dreamcast

[Paul Mundt]

On Sun, Dec 16, 2007 at 12:20:54AM +0000, Adrian McMenamin wrote:
> This device is electrically compatible with ATA-3 IDE CD drives but
> implements a proprietary packet interface. There have been previous
> Dreamcast CD drivers around but this is new code and uses DMA as
> opposed to PIO for reads.
> 
> It also supports reading the proprietary GD Rom format disks.
> 
> The driver will live as drivers/sh/gdrom/gdrom.c
> 
No, the driver will live in drivers/cdrom if that's the API that you
depend on. The only things in drivers/sh are SH-specific bus support
code, it is not a dumping ground for unrelated drivers.

Re: [PATCH 0/3] Add GD-Rom support to the SEGA Dreamcast

[Adrian McMenamin]

On Sun, 2007-12-16 at 13:13 +0900, Paul Mundt wrote:
> On Sun, Dec 16, 2007 at 12:20:54AM +0000, Adrian McMenamin wrote:
> > This device is electrically compatible with ATA-3 IDE CD drives but
> > implements a proprietary packet interface. There have been previous
> > Dreamcast CD drivers around but this is new code and uses DMA as
> > opposed to PIO for reads.
> > 
> > It also supports reading the proprietary GD Rom format disks.
> > 
> > The driver will live as drivers/sh/gdrom/gdrom.c
> > 
> No, the driver will live in drivers/cdrom if that's the API that you
> depend on. The only things in drivers/sh are SH-specific bus support
> code, it is not a dumping ground for unrelated drivers.


Well, the other cd drives exist in mainline outside that directory eg
drivers/block/paride/pcd.c  drivers/ide/ide-cd.c drivers/scsi/sr.c 

As far as I can see if this joins mainline it will be the only
proprietary CD device - there were six others which were
in /drivers/cdrom but they were purged recently.

I'm not bothered where it goes, though.