From: Christoph Hellwig <hch@infradead.org>
To: Paul Mundt <lethal@linux-sh.org>,
Adrian McMenamin <lkmladrian@gmail.com>,
linux-kernel@vger.kernel.org, linux-ide@vger.kernel.org,
linux-sh@vger.kernel.org, axboe@kernel.dk
Subject: Re: [PATCH 2/3] Add GD-Rom support to the SEGA Dreamcast
Date: Sun, 16 Dec 2007 10:09:13 +0000 [thread overview]
Message-ID: <20071216100913.GA1208@infradead.org> (raw)
In-Reply-To: <20071216095019.GA12184@linux-sh.org>
On Sun, Dec 16, 2007 at 06:50:19PM +0900, Paul Mundt wrote:
> > +static irqreturn_t gdrom_command_interrupt(int irq, void *dev_id)
> > +{
> > + if (dev_id != &gd)
> > + return IRQ_NONE;
>
> You aren't setting this up as a shared IRQ, so this shouldn't be
> necessary.
It's not nessecary for shared irqs either. The irq code will never
pass you a different cookied back than the one you passed in.
Everything else would be a nighmare and these cargo cult workarounds
wouldn't help either.
next prev parent reply other threads:[~2007-12-16 10:09 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-16 0:21 [PATCH 2/3] Add GD-Rom support to the SEGA Dreamcast Adrian McMenamin
2007-12-16 9:50 ` Paul Mundt
2007-12-16 10:09 ` Christoph Hellwig [this message]
2007-12-16 17:32 ` Adrian McMenamin
2007-12-16 21:59 ` Paul Mundt
2007-12-17 0:06 ` Adrian McMenamin
2007-12-16 18:05 ` Adrian McMenamin
2007-12-17 23:20 ` Jan Engelhardt
2007-12-20 21:53 ` Adrian McMenamin
2007-12-21 5:24 ` Paul Mundt
2007-12-16 21:01 ` Mike Frysinger
2007-12-17 14:06 ` Jens Axboe
2007-12-17 14:36 ` Adrian McMenamin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071216100913.GA1208@infradead.org \
--to=hch@infradead.org \
--cc=axboe@kernel.dk \
--cc=lethal@linux-sh.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=lkmladrian@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).