linux-ide.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
To: linux-ide@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH 00/63] ide-cd: redux
Date: Thu, 20 Dec 2007 01:48:49 +0100	[thread overview]
Message-ID: <200712200148.49690.bzolnier@gmail.com> (raw)


Hi,

This patch series is a major rework of the ide-cd driver.

The motivations behind it are twofold:

* ide-cd is still in use but because it has been out of luck for maintainers
  lately the code become quite hard to debug and maintain - this puts it back
  into the shape

* aid efforts of developers (Tejun and Alan) who are working on libata ATAPI
  support - it should be now a lot easier to spot the various quirks for
  weird/buggy devices, differences between sr/ide-cd etc.

This patch series contains only safe/straightforward changes (some "risky"
ones are scheduled for later time) and should be fully bisectable.


Changes:

* unify _four_ slightly different IRQ handlers into one

* re-organize handling of quirky-devices (group quirks scattered
  all over the driver in the table and handle them using flags)

* move code for verbose error logging to ide-cd_verbose.c (this
  code doesn't have any IDE subsystem dependencies so if desired
  it can be easily converted into generic IDE/libata library)

* move code handling cdrom.c IOCTLs to ide-cd_ioctl.c

* remove duplicated/dead code (> 700 LOC gone)

* move historical changelog to Documentation/ide/

* fix few bugs discovered during rewrite


diffstat:

 Documentation/ide/ChangeLog.ide-cd.1994-2004 |  268 ++
 drivers/cdrom/cdrom.c                        |    6
 drivers/ide/Kconfig                          |    9
 drivers/ide/Makefile                         |    6
 drivers/ide/ide-cd.c                         | 3236 +++++++++------------------
 drivers/ide/ide-cd.h                         |  737 ------
 drivers/ide/ide-cd_ioctl.c                   |  265 ++
 drivers/ide/ide-cd_verbose.c                 |  359 ++
 include/linux/cdrom.h                        |   14
 9 files changed, 2095 insertions(+), 2805 deletions(-)


PS ide-cd Maintainer position is still open...

Thanks,
Bart

             reply	other threads:[~2007-12-20  0:48 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-12-20  0:48 Bartlomiej Zolnierkiewicz [this message]
2007-12-20 12:11 ` [PATCH 00/63] ide-cd: redux Borislav Petkov
2007-12-21 19:57   ` Bartlomiej Zolnierkiewicz
2007-12-23  6:55     ` Borislav Petkov
2007-12-23 21:39       ` Bartlomiej Zolnierkiewicz
2007-12-20 20:26 ` Phillip Susi
2007-12-21 19:57   ` Bartlomiej Zolnierkiewicz
2007-12-25 22:05 ` Andrew Morton
2007-12-26 15:43   ` Borislav Petkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200712200148.49690.bzolnier@gmail.com \
    --to=bzolnier@gmail.com \
    --cc=linux-ide@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).