From: Adrian Bunk <bunk@kernel.org>
To: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Cc: linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] ide: use MODULE_VERSION()
Date: Tue, 1 Jan 2008 19:53:34 +0200 [thread overview]
Message-ID: <20080101175333.GA27566@does.not.exist> (raw)
In-Reply-To: <200801011840.38757.bzolnier@gmail.com>
On Tue, Jan 01, 2008 at 06:40:38PM +0100, Bartlomiej Zolnierkiewicz wrote:
>
> * Replace driver versions in comments by DRV_VERSION define.
>
> * Add MODULE_VERSION(DRV_VERSION) to drivers defining DRV_VERSION.
>...
Could you limit this to actively maintained version numbers and also
remove the others from .version, printk's,...?
An example:
> --- a/drivers/ide/legacy/umc8672.c
> +++ b/drivers/ide/legacy/umc8672.c
> @@ -1,5 +1,5 @@
> /*
> - * linux/drivers/ide/legacy/umc8672.c Version 0.05 Jul 31, 1996
> + * linux/drivers/ide/legacy/umc8672.c
> *
> * Copyright (C) 1995-1996 Linus Torvalds & author (see below)
> */
> @@ -53,6 +53,8 @@
>
> #include <asm/io.h>
>
> +#define DRV_VERSION "0.05"
> +
> /*
> * Default speeds. These can be changed with "auto-tune" and/or hdparm.
> */
> @@ -185,3 +187,4 @@ module_init(umc8672_init);
> MODULE_AUTHOR("Wolfram Podien");
> MODULE_DESCRIPTION("Support for UMC 8672 IDE chipset");
> MODULE_LICENSE("GPL");
> +MODULE_VERSION(DRV_VERSION);
>...
I do not see any value in printing a version number from 1996 (sic),
and the driver has for sure changed without any update of the
version number.
For actively maintained version numbers (and even more when
distributions backport more recent versions of a driver) printing a
(maintained) driver version number makes sense, but otherwise the kernel
version contains more information and a stale version number only gives
the false impression the driver hadn't changed.
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
next prev parent reply other threads:[~2008-01-01 17:53 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-01 17:40 [PATCH 1/3] ide: use MODULE_VERSION() Bartlomiej Zolnierkiewicz
2008-01-01 17:53 ` Adrian Bunk [this message]
2008-01-01 18:33 ` Bartlomiej Zolnierkiewicz
2008-01-02 2:32 ` Jon Masters
2008-01-02 4:46 ` Matt Domsch
2008-01-02 5:46 ` Jon Masters
2008-01-02 14:40 ` Stefan Richter
2008-01-02 22:45 ` Bartlomiej Zolnierkiewicz
2008-01-02 22:40 ` Matt Domsch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080101175333.GA27566@does.not.exist \
--to=bunk@kernel.org \
--cc=bzolnier@gmail.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).