Re: [RESEND PATCH 03/10] ide-floppy: convert to generic packet commands

[Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>]

On Thursday 03 January 2008, Borislav Petkov wrote:
> Replace the ide-floppy packet commands opcode defines with the generic ones.
> Add a missing GPCMD_WRITE_12 (opcode 0xaa) to the generic ones in cdrom.h. The
> last one can be found in the current version of INF-8090, p.905.
> 
> CC: Jens Axboe <axboe@kernel.dk>
> Signed-off-by: Borislav Petkov <bbpetkov@yahoo.de>

please move this patch at the beggining of the patch series so it can be
applied immediately (patch #2 needs some more work)

> ---
>  drivers/ide/ide-floppy.c |   26 +++++++++++++-------------
>  drivers/ide/ide-floppy.h |   21 ---------------------

Please also note that patch #2 moved these defines to ide-floppy.h and now
patch #3 removes them so by re-ordering patches you can make patch #2 simpler.

[ This is a general hint for optimizing patches to make them smaller and easier
  to maintain, it also makes reviewer's job easier. ]

[...]

> --- a/include/linux/cdrom.h
> +++ b/include/linux/cdrom.h
> @@ -480,6 +480,7 @@ struct cdrom_generic_command
>  #define GPCMD_TEST_UNIT_READY		    0x00
>  #define GPCMD_VERIFY_10			    0x2f
>  #define GPCMD_WRITE_10			    0x2a
> +#define GPCMD_WRITE_12			    0xaa	/* ide floppy */

0xaa is a generic SCSI opcode so the above comment is not necessary

>  #define GPCMD_WRITE_AND_VERIFY_10	    0x2e
>  /* This is listed as optional in ATAPI 2.6, but is (curiously) 
>   * missing from Mt. Fuji, Table 57.  It _is_ mentioned in Mt. Fuji