Re: [RFC PATCH] ide-floppy: remove struct idefloppy_capabilities_page

[Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>]

On Sunday 06 January 2008, Borislav Petkov wrote:
> Hi Bart,
> 
> before removing all those typedefs in ide-floppy i wanted to check with you whether what
> i have in mind is in the right direction before doing all the work for nothing.
> Here's the first patch removing struct idefloppy_capabilities_page. Please, tell
> me whether it is similar to what you guys have in mind or is it missing the
> point.
> 
> Thanks.

You are 100% on the right track. :)

> From 41c791f40e3fcf2287aa245f25796fa58bb17afc Mon Sep 17 00:00:00 2001
> From: Borislav Petkov <bbpetkov@yahoo.de>
> Date: Sun, 6 Jan 2008 10:37:47 +0100
> Subject: [PATCH] ide-floppy: remove struct idefloppy_capabilities_page
> 
> This change is rather temporary and is in preparation of using generic commands
> as is the case with ide-cd and the uniform cdrom layer (i.e. init_cdrom_command())
> However, before this happens, we'll have to remove all typedefs and teach
> idefloppy_create_mode_sense_cmd() to work directly on u8 buffers.
> 
> Also, since idefloppy_get_capability_page() was used to read only the sfrp bit,
> rename the latter so that the name reflects what it does.
> 
> Signed-off-by: Borislav Petkov <bbpetkov@yahoo.de>

applied