From: Alan Cox <alan@redhat.com>
To: Jeff Garzik <jeff@garzik.org>
Cc: akpm@linux-foundation.org, alan@lxorguk.ukuu.org.uk,
alan@redhat.com, htejun@gmail.com,
Linux IDE mailing list <linux-ide@vger.kernel.org>
Subject: Re: [patch for 2.6.24? 1/1] libata: correct handling of TSS DVD
Date: Tue, 15 Jan 2008 16:01:59 -0500 [thread overview]
Message-ID: <20080115210159.GA13282@devserv.devel.redhat.com> (raw)
In-Reply-To: <478D1CF9.1040707@garzik.org>
On Tue, Jan 15, 2008 at 03:52:09PM -0500, Jeff Garzik wrote:
> > {
> >- if (ata_id_is_sata(dev_id))
> >- return 0; /* SATA */
> > if ((dev_id[93] & 0x2000) == 0x2000)
> > return 0; /* 80 wire */
> > return 1;
>
>
> Alan, is this .24 material?
>
> There were a lot of different threads and BZs about this one device, and
> I want to triple-check that multiple fixes are not being applied
> independently for the same problem.
Yes.
Without this fix a TSScorp CD-ROM on 40 wire ata reports itself as SATA
Alan
prev parent reply other threads:[~2008-01-15 21:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200801140906.m0E96Ks2020536@imap1.linux-foundation.org>
2008-01-15 20:52 ` [patch for 2.6.24? 1/1] libata: correct handling of TSS DVD Jeff Garzik
2008-01-15 21:01 ` Alan Cox [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080115210159.GA13282@devserv.devel.redhat.com \
--to=alan@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=htejun@gmail.com \
--cc=jeff@garzik.org \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).