From: Matthew Wilcox <matthew@wil.cx>
To: Matt Mackall <mpm@selenic.com>
Cc: Tejun Heo <htejun@gmail.com>,
linux-kernel@vger.kernel.org, daniel.ritz-ml@swissonline.ch,
randy.dunlap@oracle.com, jeff@garzik.org,
linux-ide@vger.kernel.org
Subject: Re: [PATCHSET] printk: implement printk_header() and merging printk
Date: Fri, 18 Jan 2008 11:44:57 -0700 [thread overview]
Message-ID: <20080118184457.GC20490@parisc-linux.org> (raw)
In-Reply-To: <1200681668.25782.9.camel@cinder.waste.org>
On Fri, Jan 18, 2008 at 12:41:08PM -0600, Matt Mackall wrote:
> On Wed, 2008-01-16 at 10:00 +0900, Tejun Heo wrote:
> > And mprintk the following.
> >
> > code:
> > DEFINE_MPRINTK(mp, 2 * 80);
> >
> > mprintk_set_header(&mp, KERN_INFO "ata%u.%2u: ", 1, 0);
> > mprintk_push(&mp, "ATA %d", 7);
> > mprintk_push(&mp, ", %u sectors\n", 1024);
> > mprintk(&mp, "everything seems dandy\n");
>
> I prefer Matthew Wilcox's stringbuf approach which does proper memory
> management and isn't specific to printk:
>
> http://www.ussg.iu.edu/hypermail/linux/kernel/0710.3/0517.html
Do you have any strong feelings whether we should merge my stringbufs or
rusty's version? I have no particular preference.
--
Intel are signing my paycheques ... these opinions are still mine
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours. We can't possibly take such
a retrograde step."
next prev parent reply other threads:[~2008-01-18 18:44 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-16 1:00 [PATCHSET] printk: implement printk_header() and merging printk Tejun Heo
2008-01-16 1:00 ` [PATCH 1/4] printk: keep log level on multiline messages Tejun Heo
2008-01-16 1:00 ` [PATCH 2/4] printk: implement [v]printk_header() Tejun Heo
2008-01-16 1:00 ` [PATCH 3/4] printk: implement merging printk Tejun Heo
2008-01-16 3:02 ` Randy Dunlap
2008-01-16 3:08 ` Tejun Heo
2008-01-16 1:00 ` [PATCH 4/4] libata: make libata use printk_header() and mprintk Tejun Heo
2008-01-16 2:48 ` Randy Dunlap
2008-01-16 2:53 ` Tejun Heo
2008-01-16 1:07 ` [PATCHSET] printk: implement printk_header() and merging printk Tejun Heo
2008-01-16 2:48 ` Randy Dunlap
2008-01-16 2:58 ` Tejun Heo
2008-01-18 18:41 ` Matt Mackall
2008-01-18 18:44 ` Matthew Wilcox [this message]
2008-01-18 19:06 ` Matt Mackall
2008-01-18 22:58 ` Tejun Heo
2008-01-21 21:42 ` Matt Mackall
2008-01-22 1:00 ` Tejun Heo
2008-01-22 1:28 ` Matt Mackall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080118184457.GC20490@parisc-linux.org \
--to=matthew@wil.cx \
--cc=daniel.ritz-ml@swissonline.ch \
--cc=htejun@gmail.com \
--cc=jeff@garzik.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mpm@selenic.com \
--cc=randy.dunlap@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).