From mboxrd@z Thu Jan 1 00:00:00 1970 From: Borislav Petkov Subject: Re: [PATCH 0/32] ide-tape redux v1 Date: Mon, 28 Jan 2008 06:43:43 +0100 Message-ID: <20080128054343.GB3074@gollum.tnic> References: <1201423312-2460-1-git-send-email-bbpetkov@yahoo.de> <200801272045.40712.bzolnier@gmail.com> Reply-To: petkovbb@gmail.com Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from [212.23.103.107] ([212.23.103.107]:65500 "EHLO gollum.tnic" rhost-flags-FAIL-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1755495AbYA2EuB (ORCPT ); Mon, 28 Jan 2008 23:50:01 -0500 Content-Disposition: inline In-Reply-To: <200801272045.40712.bzolnier@gmail.com> Sender: linux-ide-owner@vger.kernel.org List-Id: linux-ide@vger.kernel.org To: Bartlomiej Zolnierkiewicz Cc: linux-kernel@vger.kernel.org, linux-ide@vger.kernel.org Hi Bart, [...] > > the BKL in idetape_write_release() with finer-grained locking etc, = probably also > > some pipeline improvements, removal of OnStream support, etc. but t= hat'll come > > later. >=20 > On-Stream support has been long gone but it seems that deprecation > warning etc. managed to survive. >=20 > w.r.t. to the pipeline-mode: it should be pipelined into /dev/null >=20 > rationale: > - it is _very_ complex > - causes errors to be deferred till the next user-space access > - direct I/O using blk_rq_map_user() will offer superior performance >=20 > the only question is whether to remove it... Well, on the one hand, since the driver is only being maintained we sho= uld not remove code that works. Also, i don't know how many users ide-tape real= ly has but, would it be worth the trouble at all? Because if nobody's using it= , we could just as well pipe the whole thing into /dev/null.. On the other h= and, the pipelining part _is_ kinda big and, right, it is not that straightfowar= d to look at it and know what it actually does - it truly is a student proje= ct :) > > Documentation/ide/ChangeLog.ide-tape.1995-2002 | 405 +++ > > drivers/ide/Kconfig | 3 +- > > drivers/ide/ide-tape.c | 4146 +++++++++---= ------------ > > 3 files changed, 1991 insertions(+), 2563 deletions(-) [...] > BTW what happend to patch #23? Well, it appeared in my lkml mailbox having gone over vger which means = at least somebody got it :). But, yeah, that was a real nightmare yesterday send= ing all those patches in one go. See, i got a stupid umts modem behind a not so= transparent proxy :) whose subnet is listed in almost every spam database on the pl= anet and whenever i try to send more than one mail i hit all sorts of mail s= erver restrictions like yahoo's maximum messages per day crap.. Gmail seems a= bit smarter ?! and scans the mail message and then says all kinds of funny = stuff :): 27 10:48:31 gollum postfix/smtp[4011]: F1710123BFD: to=3D, relay=3Dvger.kernel.org[209.132.176.167]:25, delay=3D10, delays=3D0.19/0.29/2.7/7.2, dsn=3D2.7.1, status=3Dsent (250= 2.7.1 Looks like Linux source DIFF email.. BF:; S175394= 2AbYA0Js4) what's next, probably something like: =2E..(250 3.x.x uh, ok, i'm gonna relay your mail but please have anoth= er coffee, please) ; Anyway, resending #23 to you in a private mail. --=20 Regards/Gru=DF, Boris.