* [2.6 patch] ata_piix.c: make piix_merge_scr() static
@ 2008-01-28 22:10 Adrian Bunk
2008-01-28 23:02 ` Tejun Heo
2008-02-01 16:55 ` Jeff Garzik
0 siblings, 2 replies; 3+ messages in thread
From: Adrian Bunk @ 2008-01-28 22:10 UTC (permalink / raw)
To: Tejun Heo, Jeff Garzik; +Cc: linux-ide, linux-kernel
piix_merge_scr() can become static.
Signed-off-by: Adrian Bunk <bunk@kernel.org>
---
f272ad2ac4274a59f0b43cfd65488c51855132d4
diff --git a/drivers/ata/ata_piix.c b/drivers/ata/ata_piix.c
index a65c8ae..1a5c3bf 100644
--- a/drivers/ata/ata_piix.c
+++ b/drivers/ata/ata_piix.c
@@ -1068,7 +1068,7 @@ static void piix_sidpr_write(struct ata_device *dev, unsigned int reg, u32 val)
iowrite32(val, hpriv->sidpr + PIIX_SIDPR_DATA);
}
-u32 piix_merge_scr(u32 val0, u32 val1, const int * const *merge_tbl)
+static u32 piix_merge_scr(u32 val0, u32 val1, const int * const *merge_tbl)
{
u32 val = 0;
int i, mi;
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [2.6 patch] ata_piix.c: make piix_merge_scr() static
2008-01-28 22:10 [2.6 patch] ata_piix.c: make piix_merge_scr() static Adrian Bunk
@ 2008-01-28 23:02 ` Tejun Heo
2008-02-01 16:55 ` Jeff Garzik
1 sibling, 0 replies; 3+ messages in thread
From: Tejun Heo @ 2008-01-28 23:02 UTC (permalink / raw)
To: Adrian Bunk; +Cc: Jeff Garzik, linux-ide, linux-kernel
Adrian Bunk wrote:
> piix_merge_scr() can become static.
>
> Signed-off-by: Adrian Bunk <bunk@kernel.org>
>
> ---
> f272ad2ac4274a59f0b43cfd65488c51855132d4
> diff --git a/drivers/ata/ata_piix.c b/drivers/ata/ata_piix.c
> index a65c8ae..1a5c3bf 100644
> --- a/drivers/ata/ata_piix.c
> +++ b/drivers/ata/ata_piix.c
> @@ -1068,7 +1068,7 @@ static void piix_sidpr_write(struct ata_device *dev, unsigned int reg, u32 val)
> iowrite32(val, hpriv->sidpr + PIIX_SIDPR_DATA);
> }
>
> -u32 piix_merge_scr(u32 val0, u32 val1, const int * const *merge_tbl)
> +static u32 piix_merge_scr(u32 val0, u32 val1, const int * const *merge_tbl)
> {
> u32 val = 0;
> int i, mi;
Ah.. right. Thanks. I somehow forgot static in front of it.
Acked-by: Tejun Heo <htejun@gmail.com>
--
tejun
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [2.6 patch] ata_piix.c: make piix_merge_scr() static
2008-01-28 22:10 [2.6 patch] ata_piix.c: make piix_merge_scr() static Adrian Bunk
2008-01-28 23:02 ` Tejun Heo
@ 2008-02-01 16:55 ` Jeff Garzik
1 sibling, 0 replies; 3+ messages in thread
From: Jeff Garzik @ 2008-02-01 16:55 UTC (permalink / raw)
To: Adrian Bunk; +Cc: Tejun Heo, linux-ide, linux-kernel
Adrian Bunk wrote:
> piix_merge_scr() can become static.
>
> Signed-off-by: Adrian Bunk <bunk@kernel.org>
applied
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2008-02-01 16:55 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-01-28 22:10 [2.6 patch] ata_piix.c: make piix_merge_scr() static Adrian Bunk
2008-01-28 23:02 ` Tejun Heo
2008-02-01 16:55 ` Jeff Garzik
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).