From: Jens Axboe <jens.axboe@oracle.com>
To: Florian Lohoff <flo@rfc822.org>
Cc: Nai Xia <nai.xia@gmail.com>, Roland Dreier <rdreier@cisco.com>,
Kiyoshi Ueda <k-ueda@ct.jp.nec.com>,
bzolnier@gmail.com, bbpetkov@yahoo.de,
linux-kernel@vger.kernel.org, j-nomura@ce.jp.nec.com,
linux-ide@vger.kernel.org
Subject: Re: kernel BUG at ide-cd.c:1726 in 2.6.24-03863-g0ba6c33 && -g8561b089
Date: Thu, 31 Jan 2008 16:04:18 +0100 [thread overview]
Message-ID: <20080131150418.GD15220@kernel.dk> (raw)
In-Reply-To: <20080131145341.GA32687@paradigm.rfc822.org>
On Thu, Jan 31 2008, Florian Lohoff wrote:
> On Thu, Jan 31, 2008 at 02:05:58PM +0100, Jens Axboe wrote:
> > The below fix should be enough. It's perfectly legal to have leftover
> > byte counts when the drive signals completion, happens all the time for
> > eg user issued commands where you don't know an exact byte count.
> >
> > diff --git a/drivers/ide/ide-cd.c b/drivers/ide/ide-cd.c
> > index 74c6087..bee05a3 100644
> > --- a/drivers/ide/ide-cd.c
> > +++ b/drivers/ide/ide-cd.c
> > @@ -1722,7 +1722,7 @@ static ide_startstop_t cdrom_newpc_intr(ide_drive_t *drive)
> > */
> > if ((stat & DRQ_STAT) == 0) {
> > spin_lock_irqsave(&ide_lock, flags);
> > - if (__blk_end_request(rq, 0, 0))
> > + if (__blk_end_request(rq, 0, rq->data_len))
> > BUG();
> > HWGROUP(drive)->rq = NULL;
> > spin_unlock_irqrestore(&ide_lock, flags);
> >
>
> Fixes the crash on boot for me ...
Great, thanks for confirming that. I'll make sure the patch goes
upstream today, if Linus is available.
--
Jens Axboe
next prev parent reply other threads:[~2008-01-31 15:04 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20080129.151353.48534987.k-ueda@ct.jp.nec.com>
[not found] ` <adar6g0e0g2.fsf@cisco.com>
[not found] ` <20080129.182356.70224412.k-ueda@ct.jp.nec.com>
2008-01-31 1:26 ` kernel BUG at ide-cd.c:1726 in 2.6.24-03863-g0ba6c33 && -g8561b089 Kiyoshi Ueda
2008-01-31 2:34 ` Roland Dreier
2008-01-31 7:49 ` Nai Xia
2008-01-31 13:05 ` Jens Axboe
2008-01-31 14:53 ` Florian Lohoff
2008-01-31 15:04 ` Jens Axboe [this message]
2008-02-01 21:59 ` Bartlomiej Zolnierkiewicz
2008-01-31 17:04 ` Kiyoshi Ueda
2008-01-31 18:16 ` Jens Axboe
2008-01-31 20:35 ` Kiyoshi Ueda
2008-01-31 21:37 ` Borislav Petkov
2008-01-31 22:35 ` Kiyoshi Ueda
2008-02-01 7:51 ` Borislav Petkov
2008-02-01 17:39 ` Kiyoshi Ueda
2008-02-01 18:29 ` Borislav Petkov
2008-02-01 19:37 ` Kiyoshi Ueda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080131150418.GD15220@kernel.dk \
--to=jens.axboe@oracle.com \
--cc=bbpetkov@yahoo.de \
--cc=bzolnier@gmail.com \
--cc=flo@rfc822.org \
--cc=j-nomura@ce.jp.nec.com \
--cc=k-ueda@ct.jp.nec.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nai.xia@gmail.com \
--cc=rdreier@cisco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).