From mboxrd@z Thu Jan 1 00:00:00 1970 From: Borislav Petkov Subject: Re: [PATCH 0/32] ide-tape redux v1 Date: Fri, 1 Feb 2008 09:21:52 +0100 Message-ID: <20080201082152.GE4500@gollum.tnic> References: <1201423312-2460-1-git-send-email-bbpetkov@yahoo.de> <200801272045.40712.bzolnier@gmail.com> <20080128054343.GB3074@gollum.tnic> <200801300129.56003.bzolnier@gmail.com> Reply-To: petkovbb@gmail.com Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from an-out-0708.google.com ([209.85.132.244]:60369 "EHLO an-out-0708.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753270AbYBAIWp (ORCPT ); Fri, 1 Feb 2008 03:22:45 -0500 Received: by an-out-0708.google.com with SMTP id d31so248811and.103 for ; Fri, 01 Feb 2008 00:22:44 -0800 (PST) Content-Disposition: inline In-Reply-To: <200801300129.56003.bzolnier@gmail.com> Sender: linux-ide-owner@vger.kernel.org List-Id: linux-ide@vger.kernel.org To: Bartlomiej Zolnierkiewicz Cc: linux-kernel@vger.kernel.org, linux-ide@vger.kernel.org On Wed, Jan 30, 2008 at 01:29:55AM +0100, Bartlomiej Zolnierkiewicz wro= te: > On Monday 28 January 2008, Borislav Petkov wrote: > > Hi Bart, > >=20 > > [...] > >=20 > > > > the BKL in idetape_write_release() with finer-grained locking e= tc, probably also > > > > some pipeline improvements, removal of OnStream support, etc. b= ut that'll come > > > > later. > > >=20 > > > On-Stream support has been long gone but it seems that deprecatio= n > > > warning etc. managed to survive. > > >=20 > > > w.r.t. to the pipeline-mode: it should be pipelined into /dev/nul= l > > >=20 > > > rationale: > > > - it is _very_ complex > > > - causes errors to be deferred till the next user-space access > > > - direct I/O using blk_rq_map_user() will offer superior performa= nce > > >=20 > > > the only question is whether to remove it... > >=20 > > Well, on the one hand, since the driver is only being maintained we= should not > > remove code that works. Also, i don't know how many users ide-tape = really has > > but, would it be worth the trouble at all? Because if nobody's usin= g it, we > > could just as well pipe the whole thing into /dev/null.. On the oth= er hand, the >=20 > This may be the other alternative... [ there is always libata PATA...= ] >=20 > If you want to give ide-tape removal a try, go ahead (I suggest start= ing > with adding warning printk() and keeping patch in -mm for some time).= =2E. Well, we don't have any numbers on whether someone is using the driver = at all, so i probably the best thing we should do is give it a grace period of = 1/2 year before we get rid of it. In the meantime, let's see how many souls cry = out :) --- commit 5b4566d1ed9b050d53d776285da84f8c3cc13d2c Author: Borislav Petkov Date: Fri Feb 1 09:12:02 2008 +0100 ide-tape: schedule driver for removal after 6 months in case it doe= sn't have any users left. Signed-off-by: Borislav Petkov diff --git a/Documentation/feature-removal-schedule.txt b/Documentation= /feature-removal-schedule.txt index 20c4c8b..21d71a9 100644 --- a/Documentation/feature-removal-schedule.txt +++ b/Documentation/feature-removal-schedule.txt @@ -333,3 +333,13 @@ Why: This driver has been marked obsolete for many= years. Who: Stephen Hemminger =20 --------------------------- + +What: ide-tape driver +When: July 2008 +Files: drivers/ide/ide-tape.c +Why: This driver might not have any users anymore and maintaining it f= or no + reason is an effort no one wants to make. +Who: Bartlomiej Zolnierkiewicz , Borislav Petkov + + +--------------------------- diff --git a/drivers/ide/ide-tape.c b/drivers/ide/ide-tape.c index f51712c..fd81f4c 100644 --- a/drivers/ide/ide-tape.c +++ b/drivers/ide/ide-tape.c @@ -3829,6 +3829,11 @@ static int ide_tape_probe(ide_drive_t *drive) g->fops =3D &idetape_block_ops; ide_register_region(g); =20 + printk(KERN_WARNING "It is possible that this driver does not have an= y" + " users anymore and, as a result, it will be REMOVED soon." + " Please notify Bart or Boris" + " in case you still need it.\n"); + return 0; =20 out_free_tape: --=20 Regards/Gru=DF, Boris.