Re: [PATCH 2/2 v3] sata_mv: Support SoC controllers

[Paul Mundt <lethal@linux-sh.org>]

On Fri, Feb 01, 2008 at 11:53:30AM -0500, Jeff Garzik wrote:
> saeed.bishara@gmail.com wrote:
> >--- /dev/null
> >+++ b/include/linux/sata_mv.h
> >@@ -0,0 +1,21 @@
> >+/*
> >+ * Marvell integrated SATA platfrom device data definition file.
> >+ *
> >+ * Saeed Bishara <saeed@marvell.com>
> >+ *
> >+ * This file is licensed under the terms of the GNU General Public
> >+ * License version 2. This program is licensed "as is" without any
> >+ * warranty of any kind, whether express or implied.
> >+ */
> >+
> >+#ifndef __LINUX_SATA_MV_H__
> >+#define __LINUX_SATA_MV_H__
> >+
> >+/*
> >+ * Sata private data
> >+ */
> >+struct mv_sata_platform_data {
> >+	int	n_ports; /* number of sata ports */
> >+};
> >+
> >+#endif
> 
> Overall, the patch is OK, but I fear adding way too many of these tiny 
> includes, for each platform.
> 
> Unless Paul M objects (pata_platform maintainer), I will rename 
> linux/pata_platform.h to linux/ata_platform.h, and we can put your 
> mv_sata_platform_data structure in there.
> 
No objections from me, feel free to make the best use you can out of
what's there.