* [PATCH] ide-scsi: remove needless SELECT_DRIVE() call
@ 2008-02-02 18:06 Bartlomiej Zolnierkiewicz
0 siblings, 0 replies; only message in thread
From: Bartlomiej Zolnierkiewicz @ 2008-02-02 18:06 UTC (permalink / raw)
To: linux-ide; +Cc: linux-kernel
SELECT_DRIVE() is called by IDE core code in start_request() before device
driver's ->do_request method. In ide-scsi case ->do_request is implemented
by idescsi_do_request() which is also the only user of idescsi_issue_pc().
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
---
goes before "ide: unexport SELECT_DRIVE()" patch in IDE quilt tree
drivers/scsi/ide-scsi.c | 2 --
1 file changed, 2 deletions(-)
Index: b/drivers/scsi/ide-scsi.c
===================================================================
--- a/drivers/scsi/ide-scsi.c
+++ b/drivers/scsi/ide-scsi.c
@@ -588,8 +588,6 @@ static ide_startstop_t idescsi_issue_pc
hwif->sg_mapped = 0;
}
- SELECT_DRIVE(drive);
-
ide_pktcmd_tf_load(drive, IDE_TFLAG_NO_SELECT_MASK, bcount, dma);
if (dma)
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2008-02-02 18:25 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-02-02 18:06 [PATCH] ide-scsi: remove needless SELECT_DRIVE() call Bartlomiej Zolnierkiewicz
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).