* [PATCH] ide-tape: dump gcw fields on error in idetape_identify_device()
@ 2008-02-02 18:22 Bartlomiej Zolnierkiewicz
2008-02-03 17:16 ` Sergei Shtylyov
0 siblings, 1 reply; 3+ messages in thread
From: Bartlomiej Zolnierkiewicz @ 2008-02-02 18:22 UTC (permalink / raw)
To: linux-ide; +Cc: linux-kernel, Borislav Petkov
Cc: Borislav Petkov <bbpetkov@yahoo.de>
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
---
goes before "ide-tape: remove IDETAPE_DEBUG_INFO" patch in IDE quilt tree
drivers/ide/ide-tape.c | 13 +++++++------
1 file changed, 7 insertions(+), 6 deletions(-)
Index: b/drivers/ide/ide-tape.c
===================================================================
--- a/drivers/ide/ide-tape.c
+++ b/drivers/ide/ide-tape.c
@@ -3852,16 +3852,17 @@ static int idetape_identify_device (ide_
/* Check that we can support this device */
- if (gcw.protocol !=2 )
- printk(KERN_ERR "ide-tape: Protocol is not ATAPI\n");
+ if (gcw.protocol != 2)
+ printk(KERN_ERR "ide-tape: Protocol (0x%02x) is not ATAPI\n",
+ gcw.protocol);
else if (gcw.device_type != 1)
- printk(KERN_ERR "ide-tape: Device type is not set to tape\n");
+ printk(KERN_ERR "ide-tape: Device type (0x%02x) is not set "
+ "to tape\n", gcw.device_type);
else if (!gcw.removable)
printk(KERN_ERR "ide-tape: The removable flag is not set\n");
else if (gcw.packet_size != 0) {
- printk(KERN_ERR "ide-tape: Packet size is not 12 bytes long\n");
- if (gcw.packet_size == 1)
- printk(KERN_ERR "ide-tape: Sorry, padding to 16 bytes is still not supported\n");
+ printk(KERN_ERR "ide-tape: Packet size (0x%02x) is not 12 "
+ "bytes long\n", gcw.packet_size);
} else
return 1;
return 0;
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] ide-tape: dump gcw fields on error in idetape_identify_device()
2008-02-02 18:22 [PATCH] ide-tape: dump gcw fields on error in idetape_identify_device() Bartlomiej Zolnierkiewicz
@ 2008-02-03 17:16 ` Sergei Shtylyov
2008-02-04 11:36 ` Borislav Petkov
0 siblings, 1 reply; 3+ messages in thread
From: Sergei Shtylyov @ 2008-02-03 17:16 UTC (permalink / raw)
To: Bartlomiej Zolnierkiewicz; +Cc: linux-ide, linux-kernel, Borislav Petkov
Bartlomiej Zolnierkiewicz wrote:
> Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Acked-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>
> Index: b/drivers/ide/ide-tape.c
> ===================================================================
> --- a/drivers/ide/ide-tape.c
> +++ b/drivers/ide/ide-tape.c
> @@ -3852,16 +3852,17 @@ static int idetape_identify_device (ide_
>
> /* Check that we can support this device */
>
> - if (gcw.protocol !=2 )
> - printk(KERN_ERR "ide-tape: Protocol is not ATAPI\n");
> + if (gcw.protocol != 2)
> + printk(KERN_ERR "ide-tape: Protocol (0x%02x) is not ATAPI\n",
> + gcw.protocol);
> else if (gcw.device_type != 1)
> - printk(KERN_ERR "ide-tape: Device type is not set to tape\n");
> + printk(KERN_ERR "ide-tape: Device type (0x%02x) is not set "
> + "to tape\n", gcw.device_type);
> else if (!gcw.removable)
> printk(KERN_ERR "ide-tape: The removable flag is not set\n");
> else if (gcw.packet_size != 0) {
> - printk(KERN_ERR "ide-tape: Packet size is not 12 bytes long\n");
> - if (gcw.packet_size == 1)
> - printk(KERN_ERR "ide-tape: Sorry, padding to 16 bytes is still not supported\n");
> + printk(KERN_ERR "ide-tape: Packet size (0x%02x) is not 12 "
> + "bytes long\n", gcw.packet_size);
Shouldn't it be either "packet size is not 12 byted" or "packet is not 12
bytes long"?
MBR, Sergei
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] ide-tape: dump gcw fields on error in idetape_identify_device()
2008-02-03 17:16 ` Sergei Shtylyov
@ 2008-02-04 11:36 ` Borislav Petkov
0 siblings, 0 replies; 3+ messages in thread
From: Borislav Petkov @ 2008-02-04 11:36 UTC (permalink / raw)
To: Sergei Shtylyov; +Cc: Bartlomiej Zolnierkiewicz, linux-ide, linux-kernel
On Sun, Feb 03, 2008 at 08:16:42PM +0300, Sergei Shtylyov wrote:
> Bartlomiej Zolnierkiewicz wrote:
>
>> Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
>
> Acked-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>
>
>> Index: b/drivers/ide/ide-tape.c
>> ===================================================================
>> --- a/drivers/ide/ide-tape.c
>> +++ b/drivers/ide/ide-tape.c
>> @@ -3852,16 +3852,17 @@ static int idetape_identify_device (ide_
>> /* Check that we can support this device */
>> - if (gcw.protocol !=2 )
>> - printk(KERN_ERR "ide-tape: Protocol is not ATAPI\n");
>> + if (gcw.protocol != 2)
>> + printk(KERN_ERR "ide-tape: Protocol (0x%02x) is not ATAPI\n",
>> + gcw.protocol);
>> else if (gcw.device_type != 1)
>> - printk(KERN_ERR "ide-tape: Device type is not set to tape\n");
>> + printk(KERN_ERR "ide-tape: Device type (0x%02x) is not set "
>> + "to tape\n", gcw.device_type);
>> else if (!gcw.removable)
>> printk(KERN_ERR "ide-tape: The removable flag is not set\n");
>> else if (gcw.packet_size != 0) {
>> - printk(KERN_ERR "ide-tape: Packet size is not 12 bytes long\n");
>> - if (gcw.packet_size == 1)
>> - printk(KERN_ERR "ide-tape: Sorry, padding to 16 bytes is still not supported\n");
>> + printk(KERN_ERR "ide-tape: Packet size (0x%02x) is not 12 "
>> + "bytes long\n", gcw.packet_size);
>
> Shouldn't it be either "packet size is not 12 byted" or "packet is not
> 12 bytes long"?
I like the last one better. Will send a correction later on to Bart. Thanks.
--
Regards/Gruß,
Boris.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2008-02-04 11:37 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-02-02 18:22 [PATCH] ide-tape: dump gcw fields on error in idetape_identify_device() Bartlomiej Zolnierkiewicz
2008-02-03 17:16 ` Sergei Shtylyov
2008-02-04 11:36 ` Borislav Petkov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).