* [PATCH 0/3 2.6.24-git] Add HAVE_PLATFORM_PATA Kconfig
@ 2008-02-02 16:21 Ben Dooks
2008-02-02 16:21 ` [PATCH 1/3 2.6.24-git] LIBATA: Add HAVE_PATA_PLATFORM to select PATA_PLATFORM driver Ben Dooks
` (3 more replies)
0 siblings, 4 replies; 9+ messages in thread
From: Ben Dooks @ 2008-02-02 16:21 UTC (permalink / raw)
To: linux-ide, jeff, htejun
Repost of previous patch-set with email address in part 3
corrected.
^ permalink raw reply [flat|nested] 9+ messages in thread* [PATCH 1/3 2.6.24-git] LIBATA: Add HAVE_PATA_PLATFORM to select PATA_PLATFORM driver 2008-02-02 16:21 [PATCH 0/3 2.6.24-git] Add HAVE_PLATFORM_PATA Kconfig Ben Dooks @ 2008-02-02 16:21 ` Ben Dooks 2008-02-02 16:21 ` [PATCH 2/3 2.6.24-git] ARM/RPC: Use HAVE_PATA_PLATFORM to select pata platform driver Ben Dooks ` (2 subsequent siblings) 3 siblings, 0 replies; 9+ messages in thread From: Ben Dooks @ 2008-02-02 16:21 UTC (permalink / raw) To: linux-ide, jeff, htejun; +Cc: Ben Dooks [-- Attachment #1: libata-pata-kconfig.patch --] [-- Type: text/plain, Size: 1216 bytes --] Add HAVE_PATA_PLATFORM to select the pata platform driver to ensure that we do not end up with a long 'depends on' list when other users of this driver turn up. Signed-off-by: Ben Dooks <ben-linux@fluff.org> Index: linux-2.6.24-git12-pata/drivers/ata/Kconfig =================================================================== --- linux-2.6.24-git12-pata.orig/drivers/ata/Kconfig +++ linux-2.6.24-git12-pata/drivers/ata/Kconfig @@ -614,9 +614,17 @@ config PATA_WINBOND_VLB Support for the Winbond W83759A controller on Vesa Local Bus systems. +config HAVE_PATA_PLATFORM + bool + help + This is an internal configuration node for any machine that + uses pata-platform driver to enable the relevant driver in the + configuration structure without having to submit endless patches + to update the PATA_PLATFORM entry. + config PATA_PLATFORM tristate "Generic platform device PATA support" - depends on EMBEDDED || ARCH_RPC || PPC + depends on EMBEDDED || ARCH_RPC || PPC || HAVE_PATA_PLATFORM help This option enables support for generic directly connected ATA devices commonly found on embedded systems. -- Ben (ben@fluff.org, http://www.fluff.org/) 'a smiley only costs 4 bytes' ^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH 2/3 2.6.24-git] ARM/RPC: Use HAVE_PATA_PLATFORM to select pata platform driver 2008-02-02 16:21 [PATCH 0/3 2.6.24-git] Add HAVE_PLATFORM_PATA Kconfig Ben Dooks 2008-02-02 16:21 ` [PATCH 1/3 2.6.24-git] LIBATA: Add HAVE_PATA_PLATFORM to select PATA_PLATFORM driver Ben Dooks @ 2008-02-02 16:21 ` Ben Dooks 2008-02-05 19:09 ` Russell King - ARM Linux 2008-02-02 16:21 ` [PATCH 3/3 2.6.24-git] PPC/LIBATA: Select HAVE_PATA_PLATFORM for ARCH_PPC Ben Dooks 2008-02-11 23:56 ` [PATCH 0/3 2.6.24-git] Add HAVE_PLATFORM_PATA Kconfig Ben Dooks 3 siblings, 1 reply; 9+ messages in thread From: Ben Dooks @ 2008-02-02 16:21 UTC (permalink / raw) To: linux-ide, jeff, htejun; +Cc: Ben Dooks, Linux ARM Kernel, Russell King [-- Attachment #1: libata-rpc-use-have-kconfig.patch --] [-- Type: text/plain, Size: 1547 bytes --] Use HAVE_PATA_PLATFORM for ARCH_RPC Cc: Linux ARM Kernel <linux-arm-kernel@lists.arm.linux.org.uk> Cc: Russell King <rmk@arm.linux.org.uk> Signed-off-by: Ben Dooks <ben-linux@fluff.org> PATCH FOLLOWS KernelVersion: 2.6.24-git12 Index: linux-2.6.24-git12-pata/arch/arm/Kconfig =================================================================== --- linux-2.6.24-git12-pata.orig/arch/arm/Kconfig +++ linux-2.6.24-git12-pata/arch/arm/Kconfig @@ -371,6 +371,7 @@ config ARCH_RPC select FIQ select TIMER_ACORN select ARCH_MAY_HAVE_PC_FDC + select HAVE_PATA_PLATFORM select ISA_DMA_API select NO_IOPORT help Index: linux-2.6.24-git12-pata/drivers/ata/Kconfig =================================================================== --- linux-2.6.24-git12-pata.orig/drivers/ata/Kconfig +++ linux-2.6.24-git12-pata/drivers/ata/Kconfig @@ -624,7 +624,7 @@ config HAVE_PATA_PLATFORM config PATA_PLATFORM tristate "Generic platform device PATA support" - depends on EMBEDDED || ARCH_RPC || PPC || HAVE_PATA_PLATFORM + depends on EMBEDDED || PPC || HAVE_PATA_PLATFORM help This option enables support for generic directly connected ATA devices commonly found on embedded systems. -- Ben (ben@fluff.org, http://www.fluff.org/) 'a smiley only costs 4 bytes' ------------------------------------------------------------------- List admin: http://lists.arm.linux.org.uk/mailman/listinfo/linux-arm-kernel FAQ: http://www.arm.linux.org.uk/mailinglists/faq.php Etiquette: http://www.arm.linux.org.uk/mailinglists/etiquette.php ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 2/3 2.6.24-git] ARM/RPC: Use HAVE_PATA_PLATFORM to select pata platform driver 2008-02-02 16:21 ` [PATCH 2/3 2.6.24-git] ARM/RPC: Use HAVE_PATA_PLATFORM to select pata platform driver Ben Dooks @ 2008-02-05 19:09 ` Russell King - ARM Linux 0 siblings, 0 replies; 9+ messages in thread From: Russell King - ARM Linux @ 2008-02-05 19:09 UTC (permalink / raw) To: Ben Dooks; +Cc: linux-ide, jeff, htejun, Linux ARM Kernel On Sat, Feb 02, 2008 at 04:21:35PM +0000, Ben Dooks wrote: > Use HAVE_PATA_PLATFORM for ARCH_RPC > > Cc: Linux ARM Kernel <linux-arm-kernel@lists.arm.linux.org.uk> > Cc: Russell King <rmk@arm.linux.org.uk> > Signed-off-by: Ben Dooks <ben-linux@fluff.org> Patch is fine. Acked-by: Russell King <rmk+kernel@arm.linux.org.uk> Thanks. ^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH 3/3 2.6.24-git] PPC/LIBATA: Select HAVE_PATA_PLATFORM for ARCH_PPC 2008-02-02 16:21 [PATCH 0/3 2.6.24-git] Add HAVE_PLATFORM_PATA Kconfig Ben Dooks 2008-02-02 16:21 ` [PATCH 1/3 2.6.24-git] LIBATA: Add HAVE_PATA_PLATFORM to select PATA_PLATFORM driver Ben Dooks 2008-02-02 16:21 ` [PATCH 2/3 2.6.24-git] ARM/RPC: Use HAVE_PATA_PLATFORM to select pata platform driver Ben Dooks @ 2008-02-02 16:21 ` Ben Dooks 2008-02-02 19:12 ` Olof Johansson 2008-02-11 23:56 ` [PATCH 0/3 2.6.24-git] Add HAVE_PLATFORM_PATA Kconfig Ben Dooks 3 siblings, 1 reply; 9+ messages in thread From: Ben Dooks @ 2008-02-02 16:21 UTC (permalink / raw) To: linux-ide, jeff, htejun; +Cc: linuxppc-dev, Ben Dooks [-- Attachment #1: libata-ppc-use-have-kconfig.patch --] [-- Type: text/plain, Size: 1121 bytes --] Use the new HAVE_PATA_PLATFORM to select PATA_PLATFORM driver. CC: linuxppc-dev@ozlabs.org Signed-off-by: Ben Dooks <ben-linux@fluff.org> Index: linux-2.6.24-git12-pata2/arch/ppc/Kconfig =================================================================== --- linux-2.6.24-git12-pata2.orig/arch/ppc/Kconfig +++ linux-2.6.24-git12-pata2/arch/ppc/Kconfig @@ -41,6 +41,7 @@ config GENERIC_CALIBRATE_DELAY config PPC bool + select HAVE_PATA_PLATFORM default y config PPC32 Index: linux-2.6.24-git12-pata2/drivers/ata/Kconfig =================================================================== --- linux-2.6.24-git12-pata2.orig/drivers/ata/Kconfig +++ linux-2.6.24-git12-pata2/drivers/ata/Kconfig @@ -624,7 +624,7 @@ config HAVE_PATA_PLATFORM config PATA_PLATFORM tristate "Generic platform device PATA support" - depends on EMBEDDED || PPC || HAVE_PATA_PLATFORM + depends on EMBEDDED || HAVE_PATA_PLATFORM help This option enables support for generic directly connected ATA devices commonly found on embedded systems. -- Ben (ben@fluff.org, http://www.fluff.org/) 'a smiley only costs 4 bytes' ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 3/3 2.6.24-git] PPC/LIBATA: Select HAVE_PATA_PLATFORM for ARCH_PPC 2008-02-02 16:21 ` [PATCH 3/3 2.6.24-git] PPC/LIBATA: Select HAVE_PATA_PLATFORM for ARCH_PPC Ben Dooks @ 2008-02-02 19:12 ` Olof Johansson 2008-02-02 19:41 ` Ben Dooks 0 siblings, 1 reply; 9+ messages in thread From: Olof Johansson @ 2008-02-02 19:12 UTC (permalink / raw) To: Ben Dooks; +Cc: linux-ide, jeff, htejun, linuxppc-dev On Sat, Feb 02, 2008 at 04:21:36PM +0000, Ben Dooks wrote: > Use the new HAVE_PATA_PLATFORM to select PATA_PLATFORM > driver. > > CC: linuxppc-dev@ozlabs.org > Signed-off-by: Ben Dooks <ben-linux@fluff.org> What tree is this against? It doesn't apply to current mainline nor jgarzik's libata-dev upstream branch. Anyway: NACK: I like this approach but this needs to be added to arch/powerpc as well. It's actually more needed there than arch/ppc, I don't personally care if arch/ppc can't use pata_platform for the last couple of months it's still around (it's getting deleted this summer, all platforms should have moved to powerpc by then). -Olof ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 3/3 2.6.24-git] PPC/LIBATA: Select HAVE_PATA_PLATFORM for ARCH_PPC 2008-02-02 19:12 ` Olof Johansson @ 2008-02-02 19:41 ` Ben Dooks 2008-02-03 0:23 ` Olof Johansson 0 siblings, 1 reply; 9+ messages in thread From: Ben Dooks @ 2008-02-02 19:41 UTC (permalink / raw) To: Olof Johansson; +Cc: Ben Dooks, linux-ide, jeff, htejun, linuxppc-dev On Sat, Feb 02, 2008 at 01:12:39PM -0600, Olof Johansson wrote: > On Sat, Feb 02, 2008 at 04:21:36PM +0000, Ben Dooks wrote: > > Use the new HAVE_PATA_PLATFORM to select PATA_PLATFORM > > driver. > > > > CC: linuxppc-dev@ozlabs.org > > Signed-off-by: Ben Dooks <ben-linux@fluff.org> > > What tree is this against? It doesn't apply to current mainline nor > jgarzik's libata-dev upstream branch. It is a series that i've just sent to the linux-ide list, only the ppc part was cc'd to the ppc list. > Anyway: NACK: I like this approach but this needs to be added to > arch/powerpc as well. I can add that to the series. > It's actually more needed there than arch/ppc, I don't personally care > if arch/ppc can't use pata_platform for the last couple of months it's > still around (it's getting deleted this summer, all platforms should > have moved to powerpc by then). Thanks, didn't know that. -- Ben Q: What's a light-year? A: One-third less calories than a regular year. ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 3/3 2.6.24-git] PPC/LIBATA: Select HAVE_PATA_PLATFORM for ARCH_PPC 2008-02-02 19:41 ` Ben Dooks @ 2008-02-03 0:23 ` Olof Johansson 0 siblings, 0 replies; 9+ messages in thread From: Olof Johansson @ 2008-02-03 0:23 UTC (permalink / raw) To: Ben Dooks; +Cc: linux-ide, jeff, htejun, linuxppc-dev On Sat, Feb 02, 2008 at 07:41:02PM +0000, Ben Dooks wrote: > On Sat, Feb 02, 2008 at 01:12:39PM -0600, Olof Johansson wrote: > > On Sat, Feb 02, 2008 at 04:21:36PM +0000, Ben Dooks wrote: > > > Use the new HAVE_PATA_PLATFORM to select PATA_PLATFORM > > > driver. > > > > > > CC: linuxppc-dev@ozlabs.org > > > Signed-off-by: Ben Dooks <ben-linux@fluff.org> > > > > What tree is this against? It doesn't apply to current mainline nor > > jgarzik's libata-dev upstream branch. > > It is a series that i've just sent to the linux-ide list, only the ppc > part was cc'd to the ppc list. D'oh. Ok, makes more sense now. Are you planning on adding HAVE_PATA_PLATFORM to the other archs that use it as well, or keep it under EMBEDDED there? > > Anyway: NACK: I like this approach but this needs to be added to > > arch/powerpc as well. > > I can add that to the series. Ok, cool. We can probably move it in under the relevant powerpc sub-platforms over time, and that's a powerpc-specific change anyway, no need to get that through linux-ide. > > It's actually more needed there than arch/ppc, I don't personally care > > if arch/ppc can't use pata_platform for the last couple of months it's > > still around (it's getting deleted this summer, all platforms should > > have moved to powerpc by then). > > Thanks, didn't know that. No problem. :) -Olof ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 0/3 2.6.24-git] Add HAVE_PLATFORM_PATA Kconfig 2008-02-02 16:21 [PATCH 0/3 2.6.24-git] Add HAVE_PLATFORM_PATA Kconfig Ben Dooks ` (2 preceding siblings ...) 2008-02-02 16:21 ` [PATCH 3/3 2.6.24-git] PPC/LIBATA: Select HAVE_PATA_PLATFORM for ARCH_PPC Ben Dooks @ 2008-02-11 23:56 ` Ben Dooks 3 siblings, 0 replies; 9+ messages in thread From: Ben Dooks @ 2008-02-11 23:56 UTC (permalink / raw) To: Ben Dooks, libata On Sat, Feb 02, 2008 at 04:21:33PM +0000, Ben Dooks wrote: > Repost of previous patch-set with email address in part 3 > corrected. Did this get dropped in the noise, or where people awaiting changes to the ppc for this to be applied? It would be great if this could get applied in the next window. -- Ben Q: What's a light-year? A: One-third less calories than a regular year. ^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2008-02-11 23:56 UTC | newest] Thread overview: 9+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2008-02-02 16:21 [PATCH 0/3 2.6.24-git] Add HAVE_PLATFORM_PATA Kconfig Ben Dooks 2008-02-02 16:21 ` [PATCH 1/3 2.6.24-git] LIBATA: Add HAVE_PATA_PLATFORM to select PATA_PLATFORM driver Ben Dooks 2008-02-02 16:21 ` [PATCH 2/3 2.6.24-git] ARM/RPC: Use HAVE_PATA_PLATFORM to select pata platform driver Ben Dooks 2008-02-05 19:09 ` Russell King - ARM Linux 2008-02-02 16:21 ` [PATCH 3/3 2.6.24-git] PPC/LIBATA: Select HAVE_PATA_PLATFORM for ARCH_PPC Ben Dooks 2008-02-02 19:12 ` Olof Johansson 2008-02-02 19:41 ` Ben Dooks 2008-02-03 0:23 ` Olof Johansson 2008-02-11 23:56 ` [PATCH 0/3 2.6.24-git] Add HAVE_PLATFORM_PATA Kconfig Ben Dooks
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).