From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
To: Denis Cheng <crquan@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@suse.de>,
linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ide-pci-generic: kill the unused ifdef/endif/MODULE code
Date: Wed, 6 Feb 2008 02:47:59 +0100 [thread overview]
Message-ID: <200802060248.00319.bzolnier@gmail.com> (raw)
In-Reply-To: <1201942356-26897-1-git-send-email-crquan@gmail.com>
On Saturday 02 February 2008, Denis Cheng wrote:
> with module_param macro, the __setup code can be killed now:
> const __setup("all-generic-ide", ide_generic_all_on);
>
> and the module name "generic.ko" is not descriptive to its functionality,
> can be changed in Makefile, the "ide-pci-generic.ko" is better.
>
> the ide-pci-generic.all-generic-ide parameter also documented
> in Documentation/kernel-parameters.txt
>
> Signed-off-by: Denis Cheng <crquan@gmail.com>
applied, thanks
PS the other patch will take same more time to review
prev parent reply other threads:[~2008-02-06 2:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-02 8:52 [PATCH] ide-pci-generic: kill the unused ifdef/endif/MODULE code Denis Cheng
2008-02-06 1:47 ` Bartlomiej Zolnierkiewicz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200802060248.00319.bzolnier@gmail.com \
--to=bzolnier@gmail.com \
--cc=crquan@gmail.com \
--cc=gregkh@suse.de \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).