From: Andi Kleen <andi@firstfloor.org>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Andi Kleen <andi@firstfloor.org>,
bzolnier@gmail.com, linux-ide@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Prevent IDE boot ops on NUMA system in mainline
Date: Mon, 11 Feb 2008 20:04:38 +0100 [thread overview]
Message-ID: <20080211190438.GB21824@one.firstfloor.org> (raw)
In-Reply-To: <alpine.LFD.1.00.0802110936231.2920@woody.linux-foundation.org>
On Mon, Feb 11, 2008 at 09:37:18AM -0800, Linus Torvalds wrote:
>
>
> On Mon, 11 Feb 2008, Linus Torvalds wrote:
> >
> > So we should probably make pcibus_to_node() be an inline function for that
> > case
>
> Or, we could just do the ugliest patch ever, namely
>
> -#define pcibus_to_node(node) (-1)
> +#define pcibus_to_node(node) ((int)(long)(node),-1)
>
> Wow. It's so ugly it's almost wraps around and comes out the other sides
> and looks pretty.
(void)arg, ... is better. Trick originally from Jan Beulich I think
(his code is always a good source for useful new C tricks)
-Andi
next prev parent reply other threads:[~2008-02-11 19:04 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-11 0:35 [PATCH] Prevent IDE boot ops on NUMA system in mainline Andi Kleen
2008-02-11 17:33 ` Linus Torvalds
2008-02-11 17:37 ` Linus Torvalds
2008-02-11 19:04 ` Andi Kleen [this message]
2008-02-11 19:03 ` Andi Kleen
2008-02-11 19:26 ` Bartlomiej Zolnierkiewicz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080211190438.GB21824@one.firstfloor.org \
--to=andi@firstfloor.org \
--cc=bzolnier@gmail.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox