From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg KH Subject: Re: pci_get_device_reverse(), why does Calgary need this? Date: Wed, 13 Feb 2008 10:14:59 -0800 Message-ID: <20080213181459.GA8960@kroah.com> References: <20080213001506.GA13933@kroah.com> <20080213001638.GB13933@kroah.com> <20080213093225.GA16985@rhun.haifa.ibm.com> <20080213173203.GC10733@kroah.com> <20080213174711.GB22274@rhun.haifa.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from pentafluge.infradead.org ([213.146.154.40]:45898 "EHLO pentafluge.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751780AbYBMSTL (ORCPT ); Wed, 13 Feb 2008 13:19:11 -0500 Content-Disposition: inline In-Reply-To: <20080213174711.GB22274@rhun.haifa.ibm.com> Sender: linux-ide-owner@vger.kernel.org List-Id: linux-ide@vger.kernel.org To: Muli Ben-Yehuda Cc: jdmason@kudzu.us, bzolnier@gmail.com, linux-ide@vger.kernel.org, linux-pci@atrey.karlin.mff.cuni.cz, linux-kernel@vger.kernel.org, discuss@x86-64.org On Wed, Feb 13, 2008 at 07:47:11PM +0200, Muli Ben-Yehuda wrote: > On Wed, Feb 13, 2008 at 09:32:03AM -0800, Greg KH wrote: > > > Is there some reason you aren't using the "real" PCI driver api here > > and registering a pci driver for these devices? That would take the > > whole "loop over all pci devices" logic out of the code entirely. > > I recall we had a reason, but I no longer recall what it was. Some > reason the "real" PCI driver API didn't fit at the time. If someone > were to whip up a working patch, I'd happily apply it. "at the time"? It's been in place since the 2.2 days :) Is the problem that other drivers also want access to this PCI device for some reason? I'll whip up a patch for you to test with in a bit... > > > Feel free to nuke it and walk the list forward. > > > > So something like the patch below would be fine? > > Yep, looks good. > > Acked-by: Muli Ben-Yehuda thanks for reviewing this. greg k-h