From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alan Cox Subject: Re: [PATCH 11/11v2] ata: fix sparse warnings in pata_legacy.c Date: Thu, 14 Feb 2008 17:56:08 +0000 Message-ID: <20080214175608.0a361b13@core> References: <3ad7c41048d88a3f8aad098570b9fac9ff719aff.1202965399.git.harvey.harrison@gmail.com> <1202966072.2748.27.camel@brick> <20080214120206.1a52f77d@core> <1203010593.2748.43.camel@brick> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Return-path: Received: from outpipe-village-512-1.bc.nu ([81.2.110.250]:33057 "EHLO lxorguk.ukuu.org.uk" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1752869AbYBNSDx (ORCPT ); Thu, 14 Feb 2008 13:03:53 -0500 In-Reply-To: <1203010593.2748.43.camel@brick> Sender: linux-ide-owner@vger.kernel.org List-Id: linux-ide@vger.kernel.org To: Harvey Harrison Cc: Jeff Garzik , Tejun Heo , LKML , linux-ide On Thu, 14 Feb 2008 09:36:32 -0800 Harvey Harrison wrote: > Use ld_qdi and ld_winbond to avoid shadowing static int > variables qdi and winbond. The ld_ prefix refers to > legacy_data. > > drivers/ata/pata_legacy.c:777:21: warning: symbol 'qdi' shadows an earlier one > drivers/ata/pata_legacy.c:128:12: originally declared here > drivers/ata/pata_legacy.c:811:21: warning: symbol 'qdi' shadows an earlier one > drivers/ata/pata_legacy.c:128:12: originally declared here > drivers/ata/pata_legacy.c:848:21: warning: symbol 'qdi' shadows an earlier one > drivers/ata/pata_legacy.c:128:12: originally declared here > drivers/ata/pata_legacy.c:882:21: warning: symbol 'qdi' shadows an earlier one > drivers/ata/pata_legacy.c:128:12: originally declared here > drivers/ata/pata_legacy.c:1040:21: warning: symbol 'winbond' shadows an earlier one > drivers/ata/pata_legacy.c:129:12: originally declared here > > Signed-off-by: Harvey Harrison Acked-by: Alan Cox