From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Harvey Harrison <harvey.harrison@gmail.com>
Cc: Jeff Garzik <jeff@garzik.org>, linux-ide <linux-ide@vger.kernel.org>
Subject: Re: [PATCH 5/11v2] ata: replace macro with static inline in libata.h
Date: Fri, 15 Feb 2008 22:30:36 +0000 [thread overview]
Message-ID: <20080215223036.2111edd5@core> (raw)
In-Reply-To: <1203113215.15275.53.camel@brick>
On Fri, 15 Feb 2008 14:06:55 -0800
Harvey Harrison <harvey.harrison@gmail.com> wrote:
> Move to using a static inline which will force the same typechecking
> that min_t/max_t do (in this case, short). As a bonus, avoid a ton
> of sparse warnings like:
>
> drivers/ata/pata_ali.c:176:14: warning: symbol '__x' shadows an earlier one
> drivers/ata/pata_ali.c:176:14: originally declared here
>
> Due to nesting min_t macro inside max_t macro which both use a __x
> identifier internally.
NAK. This is a sparse bug, fix sparse.
next prev parent reply other threads:[~2008-02-15 22:38 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-15 22:06 [PATCH 5/11v2] ata: replace macro with static inline in libata.h Harvey Harrison
2008-02-15 22:30 ` Alan Cox [this message]
2008-02-15 22:46 ` Harvey Harrison
2008-02-15 22:53 ` Alan Cox
2008-02-15 23:08 ` Harvey Harrison
2008-02-16 0:05 ` Alan Cox
2008-02-16 0:23 ` Harvey Harrison
2008-02-16 0:36 ` Harvey Harrison
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080215223036.2111edd5@core \
--to=alan@lxorguk.ukuu.org.uk \
--cc=harvey.harrison@gmail.com \
--cc=jeff@garzik.org \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).