From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Harvey Harrison <harvey.harrison@gmail.com>
Cc: Jeff Garzik <jeff@garzik.org>,
linux-ide <linux-ide@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH 5/11v2] ata: replace macro with static inline in libata.h
Date: Fri, 15 Feb 2008 22:53:39 +0000 [thread overview]
Message-ID: <20080215225339.0e2ed4e6@core> (raw)
In-Reply-To: <1203115574.30938.6.camel@brick>
> > NAK. This is a sparse bug, fix sparse.
>
> Yes, fair enough, but that's not all the patch is about.
>
> 1) it's using a max_t and min_t to force the comparisons as shorts, why
> not just make it a static inline?
Because max_t and min_t also force the comparsion types
> 2) the static inline is a little clearer about the intent here.
Why ?
> 3) the sparse warnings are entirely secondary (and technically correct
> when the macros expand, __x is shadowed)
In a controlled manner. I guess you could make min and max use __x and __y
> 4) I may be mistaken, but I thought then when something can be written
> as a static inline instead of a macro it was preferred. At least I've
> seen akpm say so, but I'll let him speak for himself (added to CC:)
gcc still sometimes seems to optimise macros better than inlines.
Alan
next prev parent reply other threads:[~2008-02-15 23:01 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-15 22:06 [PATCH 5/11v2] ata: replace macro with static inline in libata.h Harvey Harrison
2008-02-15 22:30 ` Alan Cox
2008-02-15 22:46 ` Harvey Harrison
2008-02-15 22:53 ` Alan Cox [this message]
2008-02-15 23:08 ` Harvey Harrison
2008-02-16 0:05 ` Alan Cox
2008-02-16 0:23 ` Harvey Harrison
2008-02-16 0:36 ` Harvey Harrison
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080215225339.0e2ed4e6@core \
--to=alan@lxorguk.ukuu.org.uk \
--cc=akpm@linux-foundation.org \
--cc=harvey.harrison@gmail.com \
--cc=jeff@garzik.org \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).