From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bartlomiej Zolnierkiewicz Subject: Re: [BUID_FAILURE] next-20080215 Build failure caused by ide: rework PowerMac media-bay support Date: Sat, 16 Feb 2008 15:57:32 +0100 Message-ID: <200802161557.32788.bzolnier@gmail.com> References: <47B5D1C3.40702@linux.vnet.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Return-path: Received: from fk-out-0910.google.com ([209.85.128.187]:38319 "EHLO fk-out-0910.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755876AbYBPPQR (ORCPT ); Sat, 16 Feb 2008 10:16:17 -0500 Received: by fk-out-0910.google.com with SMTP id z23so1095552fkz.5 for ; Sat, 16 Feb 2008 07:16:14 -0800 (PST) In-Reply-To: <47B5D1C3.40702@linux.vnet.ibm.com> Content-Disposition: inline Sender: linux-ide-owner@vger.kernel.org List-Id: linux-ide@vger.kernel.org To: Kamalesh Babulal Cc: linux-kernel@vger.kernel.org, linux-ide@vger.kernel.org, linuxppc-dev@ozlabs.org, michael@ellerman.id.au, Andy Whitcroft , Andrew Morton On Friday 15 February 2008, Kamalesh Babulal wrote: > The linux-next-20080215 kernel build fails on the powerpc with > following error > > CC arch/powerpc/platforms/powermac/setup.o > In file included from arch/powerpc/platforms/powermac/setup.c:66: > include/asm/mediabay.h:29: error: syntax error before 'ide_hwif_t' > include/asm/mediabay.h:29: warning: function declaration isn't a prototype > make[2]: *** [arch/powerpc/platforms/powermac/setup.o] Error 1 > make[1]: *** [arch/powerpc/platforms/powermac] Error 2 > make: *** [arch/powerpc/platforms] Error 2 > > This build failure is caused by the ide: rework PowerMac media-bay support > patch.This problem was reported and solution suggested according to > http://lkml.org/lkml/2008/2/13/195 including the > > #include after > > #ifdef CONFIG_BLK_DEV_IDE_PMAC > > helps in fixing the build failure. Thanks, I fixed the original patch. interdiff: [...] v2: * Fix build by adding include to . (Reported by Michael/Kamalesh/Andrew). Cc: Kamalesh Babulal Cc: Michael Ellerman Cc: Andrew Morton [...] diff -u b/include/asm-powerpc/mediabay.h b/include/asm-powerpc/mediabay.h --- b/include/asm-powerpc/mediabay.h +++ b/include/asm-powerpc/mediabay.h @@ -23,6 +23,8 @@ extern int media_bay_count; #ifdef CONFIG_BLK_DEV_IDE_PMAC +#include + int check_media_bay_by_base(unsigned long base, int what); /* called by IDE PMAC host driver to register IDE controller for media bay */ int media_bay_set_ide_infos(struct device_node *which_bay, unsigned long base,