* [PATCH] ht6560b can only do up to PIO mode 4
@ 2008-02-18 13:58 Jan Evert van Grootheest
2008-02-18 22:56 ` Bartlomiej Zolnierkiewicz
0 siblings, 1 reply; 2+ messages in thread
From: Jan Evert van Grootheest @ 2008-02-18 13:58 UTC (permalink / raw)
To: linux-ide, bzolnier
[-- Attachment #1: Type: text/plain, Size: 131 bytes --]
According to the datasheet, ht6560b only supports up to PIO mode 4.
Signed-off-by: Jan Evert van Grootheest <janevert@caiway.nl>
[-- Attachment #2: ht.pio.patch --]
[-- Type: text/x-patch, Size: 753 bytes --]
--- a/drivers/ide/legacy/ht6560b.c
+++ b/drivers/ide/legacy/ht6560b.c
@@ -343,7 +343,7 @@ int __init ht6560b_init(void)
hwif->chipset = ide_ht6560b;
hwif->selectproc = &ht6560b_selectproc;
hwif->host_flags = IDE_HFLAG_ABUSE_PREFETCH;
- hwif->pio_mask = ATA_PIO5;
+ hwif->pio_mask = ATA_PIO4;
hwif->set_pio_mode = &ht6560b_set_pio_mode;
hwif->serialized = 1; /* is this needed? */
hwif->mate = mate;
@@ -351,7 +351,7 @@ int __init ht6560b_init(void)
mate->chipset = ide_ht6560b;
mate->selectproc = &ht6560b_selectproc;
mate->host_flags = IDE_HFLAG_ABUSE_PREFETCH;
- mate->pio_mask = ATA_PIO5;
+ mate->pio_mask = ATA_PIO4;
mate->set_pio_mode = &ht6560b_set_pio_mode;
mate->serialized = 1; /* is this needed? */
mate->mate = hwif;
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] ht6560b can only do up to PIO mode 4
2008-02-18 13:58 [PATCH] ht6560b can only do up to PIO mode 4 Jan Evert van Grootheest
@ 2008-02-18 22:56 ` Bartlomiej Zolnierkiewicz
0 siblings, 0 replies; 2+ messages in thread
From: Bartlomiej Zolnierkiewicz @ 2008-02-18 22:56 UTC (permalink / raw)
To: Jan Evert van Grootheest; +Cc: linux-ide
On Monday 18 February 2008, Jan Evert van Grootheest wrote:
> According to the datasheet, ht6560b only supports up to PIO mode 4.
>
> Signed-off-by: Jan Evert van Grootheest <janevert@caiway.nl>
applied, thanks!
PS I had to manually port it over 2.6.25-rc2, patch below
From: Jan Evert van Grootheest <j.e.van.grootheest@caiway.nl>
Subject: [PATCH] ht6560b can only do up to PIO mode 4
According to the datasheet, ht6560b only supports up to PIO mode 4.
[bart: manually ported it over 2.6.25-rc2]
Signed-off-by: Jan Evert van Grootheest <janevert@caiway.nl>
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
---
drivers/ide/legacy/ht6560b.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Index: b/drivers/ide/legacy/ht6560b.c
===================================================================
--- a/drivers/ide/legacy/ht6560b.c
+++ b/drivers/ide/legacy/ht6560b.c
@@ -323,7 +323,7 @@ static const struct ide_port_info ht6560
IDE_HFLAG_NO_DMA |
IDE_HFLAG_NO_AUTOTUNE |
IDE_HFLAG_ABUSE_PREFETCH,
- .pio_mask = ATA_PIO5,
+ .pio_mask = ATA_PIO4,
};
static int __init ht6560b_init(void)
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-02-19 0:50 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-02-18 13:58 [PATCH] ht6560b can only do up to PIO mode 4 Jan Evert van Grootheest
2008-02-18 22:56 ` Bartlomiej Zolnierkiewicz
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).