linux-ide.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Kamalesh Babulal <kamalesh@linux.vnet.ibm.com>,
	linux-kernel@vger.kernel.org, linux-ide@vger.kernel.org,
	apw@shadowen.org
Subject: Re: [Build Failure] 2.6.25-rc5-mm1 Build fails with allmodconfig probe_4drives undefined
Date: Tue, 11 Mar 2008 20:36:07 +0100	[thread overview]
Message-ID: <200803112036.08007.bzolnier@gmail.com> (raw)
In-Reply-To: <20080311111958.c0d3188d.akpm@linux-foundation.org>

On Tuesday 11 March 2008, Andrew Morton wrote:
> On Tue, 11 Mar 2008 18:25:02 +0530
> Kamalesh Babulal <kamalesh@linux.vnet.ibm.com> wrote:
> 
> >   MODPOST 2279 modules
> > ERROR: "probe_4drives" [drivers/ide/ide-core.ko] undefined!
> 
> Caused by ide-mm-ide-add-ide-4drives-host-driver-take-3.patch.  Applying
> that patch alone to current mainline causes the above error after i386
> `make allmodconfig'.
> 
> Just exporting the symbol doesn't fix it, so something funny is going on.

toolchain?  [ standard F7 system w/ updates here ]

> probe_4drives should not be initialised to zero.
> 
> probe_4drives should not be declared extern in drivers/ide/ide.c - please
> declare it in a header which is included by the definition site and by all
> users.

I was aware of the warnings and this was only temporary (it is already fixed
by to-be-posted-today patch which removes deprecated "idex=" kernel parameters
and makes _all_ probe_* variables static).

Thanks,
Bart

      reply	other threads:[~2008-03-11 19:23 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20080311011434.ad8c8d7d.akpm@linux-foundation.org>
2008-03-11 12:55 ` [Build Failure] 2.6.25-rc5-mm1 Build fails with allmodconfig probe_4drives undefined Kamalesh Babulal
2008-03-11 17:41   ` Andrew Morton
2008-03-11 19:35     ` Bartlomiej Zolnierkiewicz
2008-03-11 18:19   ` Andrew Morton
2008-03-11 19:36     ` Bartlomiej Zolnierkiewicz [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200803112036.08007.bzolnier@gmail.com \
    --to=bzolnier@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=apw@shadowen.org \
    --cc=kamalesh@linux.vnet.ibm.com \
    --cc=linux-ide@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).