From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
To: petkovbb@gmail.com
Cc: linux-kernel@vger.kernel.org, linux-ide@vger.kernel.org
Subject: Re: [PATCH 4/4] ide-tape: remove pipeline-specific code from idetape_add_chrdev_read_request()
Date: Wed, 12 Mar 2008 14:51:23 +0100 [thread overview]
Message-ID: <200803121451.23925.bzolnier@gmail.com> (raw)
In-Reply-To: <20080312055803.GD4266@gollum.tnic>
Hi,
On Wednesday 12 March 2008, Borislav Petkov wrote:
[...]
> > > the read request's buffer directly thru idetape_queue_rw_tail()
> > >
> > > 3. Do next request buffer allocation (tape->merge_stage)
> >
> > Isn't idetape_init_read() taking care of 3.?
>
> i wanted to have the whole handling at one place and let _init_read() only
> prepare the read. Now we don't allocate any new tape->merge_stage anymore,
> which is wrong. Originally, this happened in _init_read(), however, if we do
> idetape_queue_rw_tail(), we should alloc the new stage _after_ queueing the
The original driver doesn't do this - it just calls idetape_queue_rw_tail(),
could it be a bug in the original driver?
[ ditto for idetape_queue_rw_tail() for writes ]
> request, which means it cannot happen _init_read() now and should take place
> afterwards, i.e. as it was in the original patch, or?
next prev parent reply other threads:[~2008-03-12 13:37 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-09 17:10 [PATCH 0/4] ide-tape: remove pipeline functionality-v2 Borislav Petkov
2008-03-09 17:10 ` [PATCH 1/4] ide-tape: remove tape->cache_stage Borislav Petkov
2008-03-10 23:24 ` Bartlomiej Zolnierkiewicz
2008-03-11 6:40 ` Borislav Petkov
2008-03-09 17:10 ` [PATCH 2/4] ide-tape: remove pipeline-specific code from idetape_add_chrdev_write_request Borislav Petkov
2008-03-10 23:25 ` Bartlomiej Zolnierkiewicz
2008-03-12 5:41 ` Borislav Petkov
2008-03-12 13:51 ` Bartlomiej Zolnierkiewicz
2008-03-12 14:31 ` Bartlomiej Zolnierkiewicz
2008-03-09 17:10 ` [PATCH 3/4] ide-tape remove pipeline speed/control calculations Borislav Petkov
2008-03-10 23:25 ` Bartlomiej Zolnierkiewicz
2008-03-09 17:10 ` [PATCH 4/4] ide-tape: remove pipeline-specific code from idetape_add_chrdev_read_request() Borislav Petkov
2008-03-10 23:25 ` Bartlomiej Zolnierkiewicz
2008-03-12 5:58 ` Borislav Petkov
2008-03-12 13:51 ` Bartlomiej Zolnierkiewicz [this message]
2008-03-13 6:19 ` Borislav Petkov
2008-03-10 23:24 ` [PATCH 0/4] ide-tape: remove pipeline functionality-v2 Bartlomiej Zolnierkiewicz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200803121451.23925.bzolnier@gmail.com \
--to=bzolnier@gmail.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=petkovbb@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).